From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=33500 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PnhgH-0000uC-GP
	for qemu-devel@nongnu.org; Thu, 10 Feb 2011 20:20:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ying.huang@intel.com>) id 1PnhgG-0001Ig-28
	for qemu-devel@nongnu.org; Thu, 10 Feb 2011 20:20:17 -0500
Received: from mga01.intel.com ([192.55.52.88]:48027)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ying.huang@intel.com>) id 1PnhgF-0001IW-TA
	for qemu-devel@nongnu.org; Thu, 10 Feb 2011 20:20:15 -0500
From: Huang Ying <ying.huang@intel.com>
In-Reply-To: <4D53A737.4090204@web.de>
References: <1297220431.5180.15.camel@yhuang-dev>  <4D52498D.9060706@web.de>
	<1297297678.17407.3.camel@yhuang-dev>  <4D53A737.4090204@web.de>
Content-Type: text/plain; charset="UTF-8"
Date: Fri, 11 Feb 2011 09:20:11 +0800
Message-ID: <1297387211.30902.39.camel@yhuang-dev>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH uq/master -v2 2/2] KVM, MCE,
 unpoison memory address across reboot
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Dean@gnu.org, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, Nelson <dnelson@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Anthony Liguori <aliguori@linux.vnet.ibm.com>, Andi Kleen <andi@firstfloor.org>, Avi Kivity <avi@redhat.com>

On Thu, 2011-02-10 at 16:52 +0800, Jan Kiszka wrote:
> On 2011-02-10 01:27, Huang Ying wrote:
> >>> @@ -1882,6 +1919,7 @@ int kvm_arch_on_sigbus_vcpu(CPUState *en
> >>>                  hardware_memory_error();
> >>>              }
> >>>          }
> >>> +        kvm_hwpoison_page_add(ram_addr);
> >>>  
> >>>          if (code == BUS_MCEERR_AR) {
> >>>              /* Fake an Intel architectural Data Load SRAR UCR */
> >>> @@ -1926,6 +1964,7 @@ int kvm_arch_on_sigbus(int code, void *a
> >>>                      "QEMU itself instead of guest system!: %p\n", addr);
> >>>              return 0;
> >>>          }
> >>> +        kvm_hwpoison_page_add(ram_addr);
> >>>          kvm_mce_inj_srao_memscrub2(first_cpu, paddr);
> >>>      } else
> >>>  #endif
> >>>
> >>>
> >>
> >> Looks fine otherwise. Unless that simplification makes sense, I could
> >> offer to include this into my MCE rework (there is some minor conflict).
> >> If all goes well, that series should be posted during this week.
> 
> Please have a look at
> 
>     git://git.kiszka.org/qemu-kvm.git queues/kvm-upstream
> 
> and tell me if it works for you and your signed-off still applies.

Thanks!  Works as expected in my testing!

Best Regards,
Huang Ying