From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: patches@linaro.org
Subject: [Qemu-devel] [PATCH v2 0/2] target-arm: fix Neon VUZP, VZIP instructions
Date: Mon, 14 Feb 2011 10:22:47 +0000 [thread overview]
Message-ID: <1297678969-3433-1-git-send-email-peter.maydell@linaro.org> (raw)
This patch series fixes bugs in the Neon VZIP and VUZP instructions
by abandoning the existing inline implementations in favour of
calling out to straightforward helper functions. The inline routines
could generate 50+ TCG ops each, which is well over the recommended
limit in tcg/README for using helpers instead; they also did
not give the correct results...
I've tested these patches using the usual random instruction
generation approach.
V2 changes: moved the decoding of register numbers, size and q
flag out of the helper functions into translate.c; split the
helpers up into one per (size, q) combination.
Peter Maydell (2):
target-arm: Move Neon VUZP to helper functions
target-arm: Move Neon VZIP to helper functions
target-arm/helpers.h | 11 +++
target-arm/neon_helper.c | 186 +++++++++++++++++++++++++++++++++++++++
target-arm/translate.c | 215 +++++++++++++++-------------------------------
3 files changed, 267 insertions(+), 145 deletions(-)
next reply other threads:[~2011-02-14 10:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-14 10:22 Peter Maydell [this message]
2011-02-14 10:22 ` [Qemu-devel] [PATCH v2 1/2] target-arm: Move Neon VUZP to helper functions Peter Maydell
2011-02-14 10:22 ` [Qemu-devel] [PATCH v2 2/2] target-arm: Move Neon VZIP " Peter Maydell
2011-02-20 16:35 ` [Qemu-devel] [PATCH v2 0/2] target-arm: fix Neon VUZP, VZIP instructions Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297678969-3433-1-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).