qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vasily Khoruzhick <anarsoul@gmail.com>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Vasily Khoruzhick <anarsoul@gmail.com>
Subject: [Qemu-devel] [PATCH] Fix obvious mistake in pxa2xx i2s driver
Date: Mon, 14 Feb 2011 18:59:10 +0200	[thread overview]
Message-ID: <1297702750-32203-1-git-send-email-anarsoul@gmail.com> (raw)

RST bit is (1 << 3) bit, not (1 << 2), fix condition
that enables i2s if ENB is set and RST is not set.

Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
---
 hw/pxa2xx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/pxa2xx.c b/hw/pxa2xx.c
index d966846..68b67ae 100644
--- a/hw/pxa2xx.c
+++ b/hw/pxa2xx.c
@@ -1631,7 +1631,7 @@ static void pxa2xx_i2s_write(void *opaque, target_phys_addr_t addr,
         }
         if (value & (1 << 4))				/* EFWR */
             printf("%s: Attempt to use special function\n", __FUNCTION__);
-        s->enable = ((value ^ 4) & 5) == 5;		/* ENB && !RST*/
+        s->enable = ((value ^ (1 << 3)) & 9) == 9;		/* ENB && !RST*/
         pxa2xx_i2s_update(s);
         break;
     case SACR1:
-- 
1.7.4

             reply	other threads:[~2011-02-14 17:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-14 16:59 Vasily Khoruzhick [this message]
2011-02-20 14:19 ` [Qemu-devel] Re: [PATCH] Fix obvious mistake in pxa2xx i2s driver Vasily Khoruzhick
2011-02-20 18:24 ` [Qemu-devel] " Aurelien Jarno
2011-02-20 18:39   ` Vasily Khoruzhick
2011-02-20 18:45     ` Aurelien Jarno
2011-02-20 19:23       ` [Qemu-devel] [PATCH v2] " Vasily Khoruzhick
2011-02-20 19:29         ` [Qemu-devel] " Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1297702750-32203-1-git-send-email-anarsoul@gmail.com \
    --to=anarsoul@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).