From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=33677 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pp1ob-000450-Me for qemu-devel@nongnu.org; Mon, 14 Feb 2011 12:02:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pp1oa-0007J2-Nh for qemu-devel@nongnu.org; Mon, 14 Feb 2011 12:02:21 -0500 Received: from mail-fx0-f45.google.com ([209.85.161.45]:57920) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pp1oa-0007Ik-GJ for qemu-devel@nongnu.org; Mon, 14 Feb 2011 12:02:20 -0500 Received: by fxm12 with SMTP id 12so5580015fxm.4 for ; Mon, 14 Feb 2011 09:02:19 -0800 (PST) From: Vasily Khoruzhick Date: Mon, 14 Feb 2011 18:59:10 +0200 Message-Id: <1297702750-32203-1-git-send-email-anarsoul@gmail.com> Subject: [Qemu-devel] [PATCH] Fix obvious mistake in pxa2xx i2s driver List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "qemu-devel@nongnu.org" Cc: Vasily Khoruzhick RST bit is (1 << 3) bit, not (1 << 2), fix condition that enables i2s if ENB is set and RST is not set. Signed-off-by: Vasily Khoruzhick --- hw/pxa2xx.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pxa2xx.c b/hw/pxa2xx.c index d966846..68b67ae 100644 --- a/hw/pxa2xx.c +++ b/hw/pxa2xx.c @@ -1631,7 +1631,7 @@ static void pxa2xx_i2s_write(void *opaque, target_phys_addr_t addr, } if (value & (1 << 4)) /* EFWR */ printf("%s: Attempt to use special function\n", __FUNCTION__); - s->enable = ((value ^ 4) & 5) == 5; /* ENB && !RST*/ + s->enable = ((value ^ (1 << 3)) & 9) == 9; /* ENB && !RST*/ pxa2xx_i2s_update(s); break; case SACR1: -- 1.7.4