From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41099 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PpLDH-0005pr-Gr for qemu-devel@nongnu.org; Tue, 15 Feb 2011 08:45:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PpLDE-0005NS-2i for qemu-devel@nongnu.org; Tue, 15 Feb 2011 08:45:07 -0500 Received: from mnementh.archaic.org.uk ([81.2.115.146]:56889) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PpLDD-0005J7-Gn for qemu-devel@nongnu.org; Tue, 15 Feb 2011 08:45:03 -0500 From: Peter Maydell Date: Tue, 15 Feb 2011 13:44:45 +0000 Message-Id: <1297777490-5323-6-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1297777490-5323-1-git-send-email-peter.maydell@linaro.org> References: <1297777490-5323-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH 05/10] target-arm: Fix saturated values for Neon right shifts List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Christophe Lyon , patches@linaro.org Fix value returned by signed 8 and 16 bit qrshl helpers when the result has saturated. Signed-off-by: Peter Maydell --- target-arm/neon_helper.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c index a8885fa..7859f0b 100644 --- a/target-arm/neon_helper.c +++ b/target-arm/neon_helper.c @@ -886,7 +886,10 @@ uint64_t HELPER(neon_qrshl_u64)(CPUState *env, uint64_t val, uint64_t shiftop) dest = src1 << tmp; \ if ((dest >> tmp) != src1) { \ SET_QC(); \ - dest = src1 >> 31; \ + dest = (uint32_t)(1 << (sizeof(src1) * 8 - 1)); \ + if (src1 > 0) { \ + dest--; \ + } \ } \ }} while (0) NEON_VOP_ENV(qrshl_s8, neon_s8, 4) -- 1.7.1