* [Qemu-devel] [PATCH] vnc: Fix fatal crash with vnc reverse mode
@ 2011-02-16 19:48 Stefan Weil
2011-02-16 20:16 ` [Qemu-devel] " Anthony Liguori
2011-02-23 23:23 ` Anthony Liguori
0 siblings, 2 replies; 5+ messages in thread
From: Stefan Weil @ 2011-02-16 19:48 UTC (permalink / raw)
To: qemu-devel; +Cc: Anthony Liguori
Reverse mode is unusable:
qemu -vnc localhost:5500,reverse
crashes in vnc_refresh_server_surface because some pointers are NULL.
Fix this by calling vnc_dpy_resize (which initializes these pointers)
before calling vnc_refresh.
Cc: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
ui/vnc.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index da83adf..096b5f3 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -2349,6 +2349,7 @@ static void vnc_init_timer(VncDisplay *vd)
vd->timer_interval = VNC_REFRESH_INTERVAL_BASE;
if (vd->timer == NULL && !QTAILQ_EMPTY(&vd->clients)) {
vd->timer = qemu_new_timer(rt_clock, vnc_refresh, vd);
+ vnc_dpy_resize(vd->ds);
vnc_refresh(vd);
}
}
--
1.7.2.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Qemu-devel] Re: [PATCH] vnc: Fix fatal crash with vnc reverse mode
2011-02-16 19:48 [Qemu-devel] [PATCH] vnc: Fix fatal crash with vnc reverse mode Stefan Weil
@ 2011-02-16 20:16 ` Anthony Liguori
2011-02-23 21:57 ` Stefan Weil
2011-02-23 23:23 ` Anthony Liguori
1 sibling, 1 reply; 5+ messages in thread
From: Anthony Liguori @ 2011-02-16 20:16 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-devel
On 02/16/2011 01:48 PM, Stefan Weil wrote:
> Reverse mode is unusable:
>
> qemu -vnc localhost:5500,reverse
>
> crashes in vnc_refresh_server_surface because some pointers are NULL.
>
> Fix this by calling vnc_dpy_resize (which initializes these pointers)
> before calling vnc_refresh.
>
> Cc: Anthony Liguori<aliguori@us.ibm.com>
> Signed-off-by: Stefan Weil<weil@mail.berlios.de>
>
Nice catch!
Regards,
Anthony Liguori
> ---
> ui/vnc.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index da83adf..096b5f3 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -2349,6 +2349,7 @@ static void vnc_init_timer(VncDisplay *vd)
> vd->timer_interval = VNC_REFRESH_INTERVAL_BASE;
> if (vd->timer == NULL&& !QTAILQ_EMPTY(&vd->clients)) {
> vd->timer = qemu_new_timer(rt_clock, vnc_refresh, vd);
> + vnc_dpy_resize(vd->ds);
> vnc_refresh(vd);
> }
> }
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] Re: [PATCH] vnc: Fix fatal crash with vnc reverse mode
2011-02-16 20:16 ` [Qemu-devel] " Anthony Liguori
@ 2011-02-23 21:57 ` Stefan Weil
2011-02-23 23:24 ` Anthony Liguori
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Weil @ 2011-02-23 21:57 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel
Am 16.02.2011 21:16, schrieb Anthony Liguori:
> On 02/16/2011 01:48 PM, Stefan Weil wrote:
>> Reverse mode is unusable:
>>
>> qemu -vnc localhost:5500,reverse
>>
>> crashes in vnc_refresh_server_surface because some pointers are NULL.
>>
>> Fix this by calling vnc_dpy_resize (which initializes these pointers)
>> before calling vnc_refresh.
>>
>> Cc: Anthony Liguori<aliguori@us.ibm.com>
>> Signed-off-by: Stefan Weil<weil@mail.berlios.de>
>
> Nice catch!
>
> Regards,
>
> Anthony Liguori
What now? Will the patch be committed, is there a different fix for this
bug,
or are you planning to remove vnc because it is unmaintained?
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] Re: [PATCH] vnc: Fix fatal crash with vnc reverse mode
2011-02-16 19:48 [Qemu-devel] [PATCH] vnc: Fix fatal crash with vnc reverse mode Stefan Weil
2011-02-16 20:16 ` [Qemu-devel] " Anthony Liguori
@ 2011-02-23 23:23 ` Anthony Liguori
1 sibling, 0 replies; 5+ messages in thread
From: Anthony Liguori @ 2011-02-23 23:23 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-devel
On 02/16/2011 01:48 PM, Stefan Weil wrote:
> Reverse mode is unusable:
>
> qemu -vnc localhost:5500,reverse
>
> crashes in vnc_refresh_server_surface because some pointers are NULL.
>
> Fix this by calling vnc_dpy_resize (which initializes these pointers)
> before calling vnc_refresh.
>
> Cc: Anthony Liguori<aliguori@us.ibm.com>
> Signed-off-by: Stefan Weil<weil@mail.berlios.de>
>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> ui/vnc.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index da83adf..096b5f3 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -2349,6 +2349,7 @@ static void vnc_init_timer(VncDisplay *vd)
> vd->timer_interval = VNC_REFRESH_INTERVAL_BASE;
> if (vd->timer == NULL&& !QTAILQ_EMPTY(&vd->clients)) {
> vd->timer = qemu_new_timer(rt_clock, vnc_refresh, vd);
> + vnc_dpy_resize(vd->ds);
> vnc_refresh(vd);
> }
> }
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] Re: [PATCH] vnc: Fix fatal crash with vnc reverse mode
2011-02-23 21:57 ` Stefan Weil
@ 2011-02-23 23:24 ` Anthony Liguori
0 siblings, 0 replies; 5+ messages in thread
From: Anthony Liguori @ 2011-02-23 23:24 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-devel
On 02/23/2011 03:57 PM, Stefan Weil wrote:
> Am 16.02.2011 21:16, schrieb Anthony Liguori:
>> On 02/16/2011 01:48 PM, Stefan Weil wrote:
>>> Reverse mode is unusable:
>>>
>>> qemu -vnc localhost:5500,reverse
>>>
>>> crashes in vnc_refresh_server_surface because some pointers are NULL.
>>>
>>> Fix this by calling vnc_dpy_resize (which initializes these pointers)
>>> before calling vnc_refresh.
>>>
>>> Cc: Anthony Liguori<aliguori@us.ibm.com>
>>> Signed-off-by: Stefan Weil<weil@mail.berlios.de>
>>
>> Nice catch!
>>
>> Regards,
>>
>> Anthony Liguori
>
>
> What now? Will the patch be committed, is there a different fix for
> this bug,
> or are you planning to remove vnc because it is unmaintained?
Cute.
Regards,
Anthony Liguori
>
> Stefan
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-02-23 23:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-16 19:48 [Qemu-devel] [PATCH] vnc: Fix fatal crash with vnc reverse mode Stefan Weil
2011-02-16 20:16 ` [Qemu-devel] " Anthony Liguori
2011-02-23 21:57 ` Stefan Weil
2011-02-23 23:24 ` Anthony Liguori
2011-02-23 23:23 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).