From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41596 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PquCY-0000Ux-M4 for qemu-devel@nongnu.org; Sat, 19 Feb 2011 16:18:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PquCL-0006Z9-Qr for qemu-devel@nongnu.org; Sat, 19 Feb 2011 16:18:45 -0500 Received: from moutng.kundenserver.de ([212.227.126.187]:59489) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PquCL-0006Xs-CK for qemu-devel@nongnu.org; Sat, 19 Feb 2011 16:18:37 -0500 From: Stefan Weil Date: Sat, 19 Feb 2011 22:18:11 +0100 Message-Id: <1298150292-16158-1-git-send-email-weil@mail.berlios.de> Subject: [Qemu-devel] [PATCH 1/2] block/vdi: Don't ignore immediate read/write failures List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf This patch is similar to 171e3d6b9997c98a97d0c525867f7cd9b640cadd which fixed qcow2: Returning -EIO is far from optimal, but at least it's an error code. Cc: Kevin Wolf Signed-off-by: Stefan Weil --- block/vdi.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/block/vdi.c b/block/vdi.c index 083266e..701745b 100644 --- a/block/vdi.c +++ b/block/vdi.c @@ -610,6 +610,7 @@ static void vdi_aio_read_cb(void *opaque, int ret) acb->hd_aiocb = bdrv_aio_readv(bs->file, offset, &acb->hd_qiov, n_sectors, vdi_aio_read_cb, acb); if (acb->hd_aiocb == NULL) { + ret = -EIO; goto done; } } @@ -673,6 +674,7 @@ static void vdi_aio_write_cb(void *opaque, int ret) acb->hd_aiocb = bdrv_aio_writev(bs->file, 0, &acb->hd_qiov, 1, vdi_aio_write_cb, acb); if (acb->hd_aiocb == NULL) { + ret = -EIO; goto done; } return; @@ -702,6 +704,7 @@ static void vdi_aio_write_cb(void *opaque, int ret) acb->hd_aiocb = bdrv_aio_writev(bs->file, offset, &acb->hd_qiov, n_sectors, vdi_aio_write_cb, acb); if (acb->hd_aiocb == NULL) { + ret = -EIO; goto done; } return; @@ -752,6 +755,7 @@ static void vdi_aio_write_cb(void *opaque, int ret) &acb->hd_qiov, s->block_sectors, vdi_aio_write_cb, acb); if (acb->hd_aiocb == NULL) { + ret = -EIO; goto done; } } else { @@ -764,6 +768,7 @@ static void vdi_aio_write_cb(void *opaque, int ret) acb->hd_aiocb = bdrv_aio_writev(bs->file, offset, &acb->hd_qiov, n_sectors, vdi_aio_write_cb, acb); if (acb->hd_aiocb == NULL) { + ret = -EIO; goto done; } } -- 1.7.2.3