From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35149 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PrEtX-0007ap-9J for qemu-devel@nongnu.org; Sun, 20 Feb 2011 14:24:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PrEtW-0004FX-5j for qemu-devel@nongnu.org; Sun, 20 Feb 2011 14:24:35 -0500 Received: from mail-bw0-f45.google.com ([209.85.214.45]:32990) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PrEtV-0004FE-T5 for qemu-devel@nongnu.org; Sun, 20 Feb 2011 14:24:34 -0500 Received: by bwz16 with SMTP id 16so876733bwz.4 for ; Sun, 20 Feb 2011 11:24:33 -0800 (PST) From: Vasily Khoruzhick Date: Sun, 20 Feb 2011 21:23:59 +0200 Message-Id: <1298229839-4193-1-git-send-email-anarsoul@gmail.com> In-Reply-To: <20110220184542.GL4580@hall.aurel32.net> References: <20110220184542.GL4580@hall.aurel32.net> Subject: [Qemu-devel] [PATCH v2] Fix obvious mistake in pxa2xx i2s driver List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "qemu-devel@nongnu.org" , Aurelien Jarno Cc: Vasily Khoruzhick RST bit is (1 << 4) bit, not (1 << 3), fix condition that enables i2s if ENB is set and RST is not set. Signed-off-by: Vasily Khoruzhick --- v2: simplify expression hw/pxa2xx.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pxa2xx.c b/hw/pxa2xx.c index d966846..6e41fc6 100644 --- a/hw/pxa2xx.c +++ b/hw/pxa2xx.c @@ -1631,7 +1631,7 @@ static void pxa2xx_i2s_write(void *opaque, target_phys_addr_t addr, } if (value & (1 << 4)) /* EFWR */ printf("%s: Attempt to use special function\n", __FUNCTION__); - s->enable = ((value ^ 4) & 5) == 5; /* ENB && !RST*/ + s->enable = (value & 9) == 1; /* ENB && !RST*/ pxa2xx_i2s_update(s); break; case SACR1: -- 1.7.4