From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=45477 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PrIP5-0007o4-T9 for qemu-devel@nongnu.org; Sun, 20 Feb 2011 18:09:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PrIP4-00062I-Jk for qemu-devel@nongnu.org; Sun, 20 Feb 2011 18:09:23 -0500 Received: from mail-fx0-f45.google.com ([209.85.161.45]:36020) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PrIP4-000624-Da for qemu-devel@nongnu.org; Sun, 20 Feb 2011 18:09:22 -0500 Received: by fxm11 with SMTP id 11so618402fxm.4 for ; Sun, 20 Feb 2011 15:09:21 -0800 (PST) From: Dmitry Eremin-Solenikov Date: Mon, 21 Feb 2011 02:08:53 +0300 Message-Id: <1298243333-23799-1-git-send-email-dbaryshkov@gmail.com> Subject: [Qemu-devel] [PATCH] Register only one qbus_reset_all_fn() for system bus List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Currently reset handler is registered for System bus twice: once during bus creation and once in vl.c. Remove the second qemu_register_reset() invocation. Also while we are at it, remove incorrect check at qbus_create_inplace(): when system bus is created, main_system_bus is NULL (as it's not yet created, it cannot be set), so the check is just wrong. Signed-off-by: Dmitry Eremin-Solenikov --- hw/qdev.c | 2 +- vl.c | 3 --- 2 files changed, 1 insertions(+), 4 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 1aa1ea0..0a3c8ce 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -762,7 +762,7 @@ void qbus_create_inplace(BusState *bus, BusInfo *info, if (parent) { QLIST_INSERT_HEAD(&parent->child_bus, bus, sibling); parent->num_child_bus++; - } else if (bus != main_system_bus) { + } else { /* TODO: once all bus devices are qdevified, only reset handler for main_system_bus should be registered here. */ qemu_register_reset(qbus_reset_all_fn, bus); diff --git a/vl.c b/vl.c index 91be92e..24923db 100644 --- a/vl.c +++ b/vl.c @@ -3120,9 +3120,6 @@ int main(int argc, char **argv, char **envp) exit(1); } - /* TODO: once all bus devices are qdevified, this should be done - * when bus is created by qdev.c */ - qemu_register_reset(qbus_reset_all_fn, sysbus_get_default()); qemu_run_machine_init_done_notifiers(); qemu_system_reset(); -- 1.7.2.3