From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 04/21] replace qemu_thread_equal API with qemu_thread_is_current
Date: Mon, 21 Feb 2011 09:43:23 +0100 [thread overview]
Message-ID: <1298277820-8817-5-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1298277820-8817-1-git-send-email-pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
cpus.c | 10 ++--------
qemu-thread.c | 4 ++--
qemu-thread.h | 2 +-
3 files changed, 5 insertions(+), 11 deletions(-)
diff --git a/cpus.c b/cpus.c
index 0f33945..aa30474 100644
--- a/cpus.c
+++ b/cpus.c
@@ -891,11 +891,8 @@ void qemu_cpu_kick_self(void)
int qemu_cpu_self(void *_env)
{
CPUState *env = _env;
- QemuThread this;
- qemu_thread_self(&this);
-
- return qemu_thread_equal(&this, env->thread);
+ return qemu_thread_is_current(env->thread);
}
void qemu_mutex_lock_iothread(void)
@@ -1023,10 +1020,7 @@ void cpu_stop_current(void)
void vm_stop(int reason)
{
- QemuThread me;
- qemu_thread_self(&me);
-
- if (!qemu_thread_equal(&me, &io_thread)) {
+ if (!qemu_thread_is_current(&io_thread)) {
qemu_system_vmstop_request(reason);
/*
* FIXME: should not return to device code in case
diff --git a/qemu-thread.c b/qemu-thread.c
index fbc78fe..28b3f80 100644
--- a/qemu-thread.c
+++ b/qemu-thread.c
@@ -181,9 +181,9 @@ void qemu_thread_self(QemuThread *thread)
thread->thread = pthread_self();
}
-int qemu_thread_equal(QemuThread *thread1, QemuThread *thread2)
+int qemu_thread_is_current(QemuThread *thread)
{
- return pthread_equal(thread1->thread, thread2->thread);
+ return pthread_equal(pthread_self(), thread->thread);
}
void qemu_thread_exit(void *retval)
diff --git a/qemu-thread.h b/qemu-thread.h
index 19bb30c..a7e35b4 100644
--- a/qemu-thread.h
+++ b/qemu-thread.h
@@ -38,7 +38,7 @@ void qemu_thread_create(QemuThread *thread,
void *arg);
void qemu_thread_signal(QemuThread *thread, int sig);
void qemu_thread_self(QemuThread *thread);
-int qemu_thread_equal(QemuThread *thread1, QemuThread *thread2);
+int qemu_thread_is_current(QemuThread *thread);
void qemu_thread_exit(void *retval);
#endif
--
1.7.3.5
next prev parent reply other threads:[~2011-02-21 8:43 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 8:43 [Qemu-devel] [PATCH uq/master 00/21] Win32 iothread support Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 01/21] unlock iothread during WaitForMultipleObjects Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 02/21] implement win32 dynticks timer Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 03/21] use win32 timer queues Paolo Bonzini
2011-02-21 8:43 ` Paolo Bonzini [this message]
2011-02-21 9:41 ` [Qemu-devel] Re: [PATCH 04/21] replace qemu_thread_equal API with qemu_thread_is_current Jan Kiszka
2011-02-21 11:14 ` Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 05/21] add win32 qemu-thread implementation Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 06/21] include qemu-thread.h early Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 07/21] add assertions on the owner of a QemuMutex Paolo Bonzini
2011-02-21 9:50 ` [Qemu-devel] " Jan Kiszka
2011-02-21 10:15 ` Paolo Bonzini
2011-02-21 10:22 ` Jan Kiszka
2011-02-21 10:23 ` Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 08/21] remove CONFIG_THREAD Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 09/21] inline cpu_halted into sole caller Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 10/21] always qemu_cpu_kick after unhalting a cpu Paolo Bonzini
2011-02-21 9:51 ` [Qemu-devel] " Jan Kiszka
2011-02-21 8:43 ` [Qemu-devel] [PATCH 11/21] exit round-robin vcpu loop if cpu->stopped is true Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 12/21] always signal pause_cond after stopping a VCPU Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 13/21] do not use timedwait on qemu_halt_cond Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 14/21] do not use timedwait on qemu_system_cond Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 15/21] do not use timedwait on qemu_pause_cond Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 16/21] do not use timedwait on qemu_cpu_cond Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 17/21] iothread stops the vcpu thread via IPI Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 18/21] move blocking of signals to qemu_signalfd_init Paolo Bonzini
2011-02-21 10:12 ` [Qemu-devel] " Jan Kiszka
2011-02-21 10:20 ` Paolo Bonzini
2011-02-21 10:26 ` Jan Kiszka
2011-02-21 8:43 ` [Qemu-devel] [PATCH 19/21] provide dummy signal init functions for win32 Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 20/21] protect qemu_cpu_kick_self for Win32 Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 21/21] add Win32 IPI service Paolo Bonzini
2011-02-21 12:00 ` [Qemu-devel] " Jan Kiszka
2011-02-21 12:15 ` Paolo Bonzini
2011-02-21 12:25 ` Jan Kiszka
2011-02-22 20:35 ` [Qemu-devel] [PATCH uq/master 00/21] Win32 iothread support Anthony Liguori
2011-02-23 7:29 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298277820-8817-5-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).