From: Jes.Sorensen@redhat.com
To: qemu-devel@nongnu.org
Cc: hch@infradead.org, kwolf@redhat.com, stefanha@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH] For AIO return -ENOSPC on short write
Date: Tue, 22 Feb 2011 11:17:59 +0100 [thread overview]
Message-ID: <1298369880-23859-1-git-send-email-Jes.Sorensen@redhat.com> (raw)
From: Jes Sorensen <Jes.Sorensen@redhat.com>
Hi,
Current AIO code returns -EINVAL on every error, even on write. In
order to be able to report some more sensible error messages, I
suggest we change it to return -ENOSPC if we are failing on a write
request and we had a partial write. It matches more what one would
expect.
One way to reproduce the strange error return is this:
1) setup a loopback device for a file (say 2GB)
2) create an LVM volume over it
3) create a qcow2 image on top of it which is larger than the 2GB
4) try and install a guest.....
Comments? any reason why this is a bad idea?
Cheers,
Jes
Jes Sorensen (1):
For AIO return -ENOSPC on short write
linux-aio.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
--
1.7.4
next reply other threads:[~2011-02-22 10:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 10:17 Jes.Sorensen [this message]
2011-02-22 10:18 ` [Qemu-devel] [PATCH] For AIO return -ENOSPC on short write Jes.Sorensen
2011-02-22 11:44 ` [Qemu-devel] " Kevin Wolf
2011-02-22 11:45 ` Jes Sorensen
2011-02-22 13:56 ` Avi Kivity
2011-02-22 15:02 ` [Qemu-devel] " Stefan Hajnoczi
2011-02-22 15:11 ` Kevin Wolf
2011-02-22 15:16 ` Stefan Hajnoczi
2011-02-22 16:59 ` [Qemu-devel] " Paolo Bonzini
2011-03-01 20:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298369880-23859-1-git-send-email-Jes.Sorensen@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=hch@infradead.org \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).