From: Chunqiang Tang <ctang@us.ibm.com>
To: qemu-devel@nongnu.org
Cc: Chunqiang Tang <ctang@us.ibm.com>
Subject: [Qemu-devel] [PATCH 23/26] FVD: add impl of interface bdrv_is_allocated()
Date: Fri, 25 Feb 2011 17:38:03 -0500 [thread overview]
Message-ID: <1298673486-3573-23-git-send-email-ctang@us.ibm.com> (raw)
In-Reply-To: <1298673486-3573-1-git-send-email-ctang@us.ibm.com>
This patch is part of the Fast Virtual Disk (FVD) proposal.
See http://wiki.qemu.org/Features/FVD.
This patch adds FVD's implementation of the bdrv_is_allocated() interface.
Signed-off-by: Chunqiang Tang <ctang@us.ibm.com>
---
block/fvd-misc.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 files changed, 67 insertions(+), 0 deletions(-)
diff --git a/block/fvd-misc.c b/block/fvd-misc.c
index 63ed168..766b62b 100644
--- a/block/fvd-misc.c
+++ b/block/fvd-misc.c
@@ -169,6 +169,73 @@ static int fvd_probe(const uint8_t * buf, int buf_size, const char *filename)
static int fvd_is_allocated(BlockDriverState * bs, int64_t sector_num,
int nb_sectors, int *pnum)
{
+ BDRVFvdState *s = bs->opaque;
+
+ if (s->prefetch_state == PREFETCH_STATE_FINISHED ||
+ sector_num >= s->base_img_sectors ||
+ !fresh_bitmap_show_sector_in_base_img(sector_num, s)) {
+ /* For the three cases that data may be saved in the FVD data file, we
+ * still need to check the underlying storage because those data could
+ * be holes in a sparse image, due to the optimization of "free write
+ * to zero-filled blocks". See Section 3.3.3 of the FVD-cow paper.
+ * This also covers the case of no base image. */
+
+ if (!s->table) {
+ return bdrv_is_allocated(s->fvd_data, s->data_offset + sector_num,
+ nb_sectors, pnum);
+ }
+
+ /* Use the table to figure it out. */
+ int64_t first_chunk = sector_num / s->chunk_size;
+ int64_t last_chunk = (sector_num + nb_sectors - 1) / s->chunk_size;
+ int allocated = !IS_EMPTY(s->table[first_chunk]);
+ int count;
+
+ if (first_chunk == last_chunk) {
+ /* All data in one chunk. */
+ *pnum = nb_sectors;
+ return allocated;
+ }
+
+ /* Data in the first chunk. */
+ count = s->chunk_size - (sector_num % s->chunk_size);
+
+ /* Full chunks. */
+ first_chunk++;
+ while (first_chunk < last_chunk) {
+ if ((allocated && IS_EMPTY(s->table[first_chunk]))
+ || (!allocated && !IS_EMPTY(s->table[first_chunk]))) {
+ *pnum = count;
+ return allocated;
+ }
+
+ count += s->chunk_size;
+ first_chunk++;
+ }
+
+ /* Data in the last chunk. */
+ if ((allocated && !IS_EMPTY(s->table[last_chunk]))
+ || (!allocated && IS_EMPTY(s->table[last_chunk]))) {
+ int nb = (sector_num + nb_sectors) % s->chunk_size;
+ count += nb ? nb : s->chunk_size;
+ }
+
+ *pnum = count;
+ return allocated;
+ }
+
+ /* Use the FVD metadata to find out sectors in the base image. */
+ int64_t end = sector_num + nb_sectors;
+ if (end > s->base_img_sectors) {
+ end = s->base_img_sectors;
+ }
+
+ int64_t next = sector_num + 1;
+ while (next < end && fresh_bitmap_show_sector_in_base_img(next, s)) {
+ next++;
+ }
+
+ *pnum = next - sector_num;
return 0;
}
--
1.7.0.4
next prev parent reply other threads:[~2011-02-25 22:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-25 22:37 [Qemu-devel] [PATCH 01/26] FVD: add simulated block driver 'blksim' Chunqiang Tang
2011-02-25 22:37 ` [Qemu-devel] [PATCH 02/26] FVD: extend qemu-io to do fully automated testing Chunqiang Tang
2011-02-25 22:37 ` [Qemu-devel] [PATCH 03/26] FVD: add fully automated test-qcow2.sh Chunqiang Tang
2011-02-25 22:37 ` [Qemu-devel] [PATCH 04/26] FVD: add fully automated test-vdi.sh Chunqiang Tang
2011-02-25 22:37 ` [Qemu-devel] [PATCH 05/26] FVD: add the 'qemu-img update' command Chunqiang Tang
2011-02-25 22:37 ` [Qemu-devel] [PATCH 06/26] FVD: skeleton of Fast Virtual Disk Chunqiang Tang
2011-02-25 22:37 ` [Qemu-devel] [PATCH 07/26] FVD: extend FVD header fvd.h to be more complete Chunqiang Tang
2011-02-25 22:37 ` [Qemu-devel] [PATCH 08/26] FVD: add debugging utilities Chunqiang Tang
2011-02-25 22:37 ` [Qemu-devel] [PATCH 09/26] FVD: add impl of interface bdrv_create() Chunqiang Tang
2011-02-25 22:37 ` [Qemu-devel] [PATCH 10/26] FVD: add impl of interface bdrv_file_open() Chunqiang Tang
2011-02-25 22:37 ` [Qemu-devel] [PATCH 11/26] FVD: add impl of interface bdrv_aio_writev() Chunqiang Tang
2011-02-25 22:37 ` [Qemu-devel] [PATCH 12/26] FVD: add impl of interface bdrv_aio_readv() Chunqiang Tang
2011-02-25 22:37 ` [Qemu-devel] [PATCH 13/26] FVD: add impl of storing data in compact image Chunqiang Tang
2011-02-25 22:37 ` [Qemu-devel] [PATCH 14/26] FVD: add impl of loading data from " Chunqiang Tang
2011-02-25 22:37 ` [Qemu-devel] [PATCH 15/26] FVD: add basic journal functionality Chunqiang Tang
2011-02-25 22:37 ` [Qemu-devel] [PATCH 16/26] FVD: add impl for buffered journal updates Chunqiang Tang
2011-02-25 22:37 ` [Qemu-devel] [PATCH 17/26] FVD: add impl of bdrv_flush() and bdrv_aio_flush() Chunqiang Tang
2011-02-25 22:37 ` [Qemu-devel] [PATCH 18/26] FVD: add support for base image prefetching Chunqiang Tang
2011-02-25 22:37 ` [Qemu-devel] [PATCH 19/26] FVD: add support for aio_cancel Chunqiang Tang
2011-02-25 22:38 ` [Qemu-devel] [PATCH 20/26] FVD: add impl of interface bdrv_get_info() Chunqiang Tang
2011-02-25 22:38 ` [Qemu-devel] [PATCH 21/26] FVD: add impl of interface bdrv_close() Chunqiang Tang
2011-02-25 22:38 ` [Qemu-devel] [PATCH 22/26] FVD: add impl of interface bdrv_update() Chunqiang Tang
2011-02-25 22:38 ` Chunqiang Tang [this message]
2011-02-25 22:38 ` [Qemu-devel] [PATCH 24/26] FVD: add impl of interface bdrv_has_zero_init() Chunqiang Tang
2011-02-25 22:38 ` [Qemu-devel] [PATCH 25/26] FVD: add impl of interface bdrv_probe() Chunqiang Tang
2011-02-25 22:38 ` [Qemu-devel] [PATCH 26/26] FVD: add fully automated test-fvd.sh Chunqiang Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298673486-3573-23-git-send-email-ctang@us.ibm.com \
--to=ctang@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).