From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=40739 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PtMGK-0002Rk-4I for qemu-devel@nongnu.org; Sat, 26 Feb 2011 10:40:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PtMGI-0007ah-Ul for qemu-devel@nongnu.org; Sat, 26 Feb 2011 10:40:51 -0500 Received: from mail-wy0-f173.google.com ([74.125.82.173]:42749) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PtMGI-0007Qr-Nu for qemu-devel@nongnu.org; Sat, 26 Feb 2011 10:40:50 -0500 Received: by mail-wy0-f173.google.com with SMTP id 29so2615616wyb.4 for ; Sat, 26 Feb 2011 07:40:50 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Sat, 26 Feb 2011 16:40:11 +0100 Message-Id: <1298734819-1960-15-git-send-email-pbonzini@redhat.com> In-Reply-To: <1298734819-1960-1-git-send-email-pbonzini@redhat.com> References: <1298734819-1960-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH v2 upstream 14/22] do not use timedwait on qemu_halt_cond List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: jan.kiszka@siemens.com, aurelien@aurel32.net The following conditions can cause cpu_has_work(env) to become true: - env->queued_work_first: run_on_cpu is already kicking the VCPU - env->stop = 1: pause_all_vcpus is already kicking the VCPU - env->stopped = 0: resume_all_vcpus is already kicking the VCPU - vm_running = 1: vm_start is calling resume_all_vcpus - env->halted = 0: see previous patch - qemu_cpu_has_work(env): when it becomes true, board code should set env->halted = 0 too. Signed-off-by: Paolo Bonzini --- cpus.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cpus.c b/cpus.c index 6cfb45b..4c3837f 100644 --- a/cpus.c +++ b/cpus.c @@ -771,7 +771,7 @@ static void qemu_tcg_wait_io_event(void) CPUState *env; while (all_cpu_threads_idle()) { - qemu_cond_timedwait(tcg_halt_cond, &qemu_global_mutex, 1000); + qemu_cond_wait(tcg_halt_cond, &qemu_global_mutex); } qemu_mutex_unlock(&qemu_global_mutex); @@ -794,7 +794,7 @@ static void qemu_tcg_wait_io_event(void) static void qemu_kvm_wait_io_event(CPUState *env) { while (cpu_thread_is_idle(env)) { - qemu_cond_timedwait(env->halt_cond, &qemu_global_mutex, 1000); + qemu_cond_wait(env->halt_cond, &qemu_global_mutex); } qemu_kvm_eat_signals(env); -- 1.7.4