From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: blauwirbel@gmail.com, jan.kiszka@siemes.com,
aurelien@aurel32.net, kvm@vger.kernel.org, mtosatti@redhat.com
Subject: [Qemu-devel] [PATCH v3 uq/master 00/22] Win32 iothread support
Date: Mon, 28 Feb 2011 10:10:02 +0100 [thread overview]
Message-ID: <1298884224-19734-1-git-send-email-pbonzini@redhat.com> (raw)
After gathering the comments about the two series I sent separately,
here is the full series for Win32 iothread support. It is based on
master, but as it touches (mostly, indeed) OS-independent parts it
is safer to get it in through uq/master.
Patches 1 to 5 are generic Win32 improvements, including the qemu-thread
implementation. To simplify the dependencies, I think it's better if
this part is also routed through uq/master.
Patches 6 to 8 are generic threading improvements, including using
PTHREAD_MUTEX_ERRORCHECK as suggested by Jan.
Patches 9 to 17 eliminate polling, replacing condition variable
timedwait with wait.
Patch 18 removes a redundant condition from the TCG cpu_exec_all
function.
Patches 19 to 21 add all necessary stubs to make iothread compile
with Win32, except the IPI calls. These are provided by patch 22.
Tested on Wine and Linux, not on "real" Windows. The series introduces
a dependency on Windows 2K or newer. I don't think either 95/98/ME
or Windows NT 3.x are reasonable host systems for QEMU, anyway.
v1->v2
I incorporated all suggestions from Jan, including his renaming patch
for qemu_*_is_self, and included Aurelien's sh4 tweak to cpu_halted.
v2->v3
Fixed structure naming, renamed qemu_signalfd_init, dropped owner
tracking in QemuMutex for now.
Aurelien Jarno (1):
target-sh4: move intr_at_halt out of cpu_halted()
Jan Kiszka (1):
Refactor thread retrieval and check
Paolo Bonzini (20):
unlock iothread during WaitForMultipleObjects
implement win32 dynticks timer
use win32 timer queues
add win32 qemu-thread implementation
include qemu-thread.h early
add assertions on the owner of a QemuMutex
remove CONFIG_THREAD
inline cpu_halted into sole caller
always qemu_cpu_kick after unhalting a cpu
exit round-robin vcpu loop if cpu->stopped is true
always signal pause_cond after stopping a VCPU
do not use timedwait on qemu_halt_cond
do not use timedwait on qemu_system_cond
do not use timedwait on qemu_pause_cond
do not use timedwait on qemu_cpu_cond
iothread stops the vcpu thread via IPI
move blocking of signals to qemu_signalfd_init
provide dummy signal init functions for win32
protect qemu_cpu_kick_self for Win32
add Win32 IPI service
Makefile.objs | 4 +-
configure | 2 -
cpu-exec.c | 9 +-
cpus.c | 298 +++++++++++++++++-----------------
exec.c | 2 +-
hw/ppc.c | 2 +
hw/sun4m.c | 10 +-
hw/sun4u.c | 4 +-
os-win32.c | 2 +
qemu-common.h | 2 +-
qemu-thread.c => qemu-thread-posix.c | 38 +++--
qemu-thread-posix.h | 18 ++
qemu-thread-win32.c | 260 +++++++++++++++++++++++++++++
qemu-thread-win32.h | 21 +++
qemu-thread.h | 31 ++--
qemu-timer.c | 89 +++++------
target-alpha/exec.h | 11 --
target-arm/exec.h | 13 --
target-cris/exec.h | 11 --
target-i386/exec.h | 12 --
target-i386/kvm.c | 4 +-
target-m68k/exec.h | 10 --
target-microblaze/exec.h | 11 --
target-mips/exec.h | 11 --
target-ppc/exec.h | 11 --
target-s390x/exec.h | 12 --
target-s390x/kvm.c | 1 +
target-sh4/cpu.h | 2 +-
target-sh4/exec.h | 11 --
target-sh4/helper.c | 4 +-
target-sh4/op_helper.c | 1 +
target-sparc/exec.h | 10 --
ui/vnc-jobs-async.c | 2 +-
33 files changed, 562 insertions(+), 367 deletions(-)
rename qemu-thread.c => qemu-thread-posix.c (81%)
create mode 100644 qemu-thread-posix.h
create mode 100644 qemu-thread-win32.c
create mode 100644 qemu-thread-win32.h
--
1.7.4
next reply other threads:[~2011-02-28 9:33 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 9:10 Paolo Bonzini [this message]
2011-02-28 9:10 ` [Qemu-devel] [PATCH v3 uq/master 01/22] unlock iothread during WaitForMultipleObjects Paolo Bonzini
2011-02-28 9:10 ` [Qemu-devel] [PATCH v3 uq/master 02/22] implement win32 dynticks timer Paolo Bonzini
2011-02-28 9:10 ` [Qemu-devel] [PATCH v3 uq/master 03/22] use win32 timer queues Paolo Bonzini
2011-02-28 9:10 ` [Qemu-devel] [PATCH v3 uq/master 04/22] Refactor thread retrieval and check Paolo Bonzini
2011-02-28 9:10 ` [Qemu-devel] [PATCH v3 uq/master 05/22] add win32 qemu-thread implementation Paolo Bonzini
2011-02-28 9:33 ` [Qemu-devel] " Stefan Hajnoczi
2011-02-28 10:14 ` [Qemu-devel] [PATCH v4 uq/master] " Paolo Bonzini
2011-02-28 9:10 ` [Qemu-devel] [PATCH v3 uq/master 06/22] include qemu-thread.h early Paolo Bonzini
2011-02-28 9:10 ` [Qemu-devel] [PATCH v3 uq/master 07/22] add assertions on the owner of a QemuMutex Paolo Bonzini
2011-02-28 9:10 ` [Qemu-devel] [PATCH v3 uq/master 08/22] remove CONFIG_THREAD Paolo Bonzini
2011-02-28 9:10 ` [Qemu-devel] [PATCH v3 uq/master 09/22] target-sh4: move intr_at_halt out of cpu_halted() Paolo Bonzini
2011-02-28 9:10 ` [Qemu-devel] [PATCH v3 uq/master 10/22] inline cpu_halted into sole caller Paolo Bonzini
2011-02-28 9:10 ` [Qemu-devel] [PATCH v3 uq/master 11/22] always qemu_cpu_kick after unhalting a cpu Paolo Bonzini
2011-02-28 9:10 ` [Qemu-devel] [PATCH v3 uq/master 12/22] exit round-robin vcpu loop if cpu->stopped is true Paolo Bonzini
2011-02-28 9:10 ` [Qemu-devel] [PATCH v3 uq/master 13/22] always signal pause_cond after stopping a VCPU Paolo Bonzini
2011-02-28 9:10 ` [Qemu-devel] [PATCH v3 uq/master 14/22] do not use timedwait on qemu_halt_cond Paolo Bonzini
2011-02-28 9:10 ` [Qemu-devel] [PATCH v3 uq/master 15/22] do not use timedwait on qemu_system_cond Paolo Bonzini
2011-02-28 9:10 ` [Qemu-devel] [PATCH v3 uq/master 16/22] do not use timedwait on qemu_pause_cond Paolo Bonzini
2011-02-28 9:10 ` [Qemu-devel] [PATCH v3 uq/master 17/22] do not use timedwait on qemu_cpu_cond Paolo Bonzini
2011-02-28 9:10 ` [Qemu-devel] [PATCH v3 uq/master 18/22] iothread stops the vcpu thread via IPI Paolo Bonzini
2011-02-28 9:10 ` [Qemu-devel] [PATCH v3 uq/master 19/22] merge all signal initialization with qemu_signalfd_init, rename Paolo Bonzini
2011-02-28 9:10 ` [Qemu-devel] [PATCH v3 uq/master 20/22] provide dummy signal init functions for win32 Paolo Bonzini
2011-02-28 9:10 ` [Qemu-devel] [PATCH v3 uq/master 21/22] protect qemu_cpu_kick_self for Win32 Paolo Bonzini
2011-02-28 9:10 ` [Qemu-devel] [PATCH v3 uq/master 22/22] add Win32 IPI service Paolo Bonzini
2011-02-28 9:16 ` [Qemu-devel] Re: [PATCH v3 uq/master 00/22] Win32 iothread support Avi Kivity
2011-02-28 10:10 ` Paolo Bonzini
2011-02-28 11:57 ` Jan Kiszka
2011-02-28 12:13 ` Avi Kivity
2011-02-28 14:05 ` Paolo Bonzini
2011-03-01 12:35 ` Avi Kivity
2011-03-02 18:43 ` Marcelo Tosatti
2011-03-02 19:03 ` Jan Kiszka
2011-03-02 19:36 ` Marcelo Tosatti
2011-03-02 19:42 ` Marcelo Tosatti
2011-03-03 8:48 ` Avi Kivity
2011-03-03 9:07 ` Jan Kiszka
2011-03-03 9:12 ` Avi Kivity
2011-03-03 9:13 ` Paolo Bonzini
2011-03-03 9:28 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298884224-19734-1-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=jan.kiszka@siemes.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).