From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=33074 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PtzTR-0001TN-NY for qemu-devel@nongnu.org; Mon, 28 Feb 2011 04:33:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ptz7l-0004dI-3f for qemu-devel@nongnu.org; Mon, 28 Feb 2011 04:10:38 -0500 Received: from mail-gx0-f173.google.com ([209.85.161.173]:57989) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ptz7k-0004dE-Tt for qemu-devel@nongnu.org; Mon, 28 Feb 2011 04:10:37 -0500 Received: by gxk28 with SMTP id 28so1785045gxk.4 for ; Mon, 28 Feb 2011 01:10:36 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Mon, 28 Feb 2011 10:10:02 +0100 Message-Id: <1298884224-19734-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH v3 uq/master 00/22] Win32 iothread support List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: blauwirbel@gmail.com, jan.kiszka@siemes.com, aurelien@aurel32.net, kvm@vger.kernel.org, mtosatti@redhat.com After gathering the comments about the two series I sent separately, here is the full series for Win32 iothread support. It is based on master, but as it touches (mostly, indeed) OS-independent parts it is safer to get it in through uq/master. Patches 1 to 5 are generic Win32 improvements, including the qemu-thread implementation. To simplify the dependencies, I think it's better if this part is also routed through uq/master. Patches 6 to 8 are generic threading improvements, including using PTHREAD_MUTEX_ERRORCHECK as suggested by Jan. Patches 9 to 17 eliminate polling, replacing condition variable timedwait with wait. Patch 18 removes a redundant condition from the TCG cpu_exec_all function. Patches 19 to 21 add all necessary stubs to make iothread compile with Win32, except the IPI calls. These are provided by patch 22. Tested on Wine and Linux, not on "real" Windows. The series introduces a dependency on Windows 2K or newer. I don't think either 95/98/ME or Windows NT 3.x are reasonable host systems for QEMU, anyway. v1->v2 I incorporated all suggestions from Jan, including his renaming patch for qemu_*_is_self, and included Aurelien's sh4 tweak to cpu_halted. v2->v3 Fixed structure naming, renamed qemu_signalfd_init, dropped owner tracking in QemuMutex for now. Aurelien Jarno (1): target-sh4: move intr_at_halt out of cpu_halted() Jan Kiszka (1): Refactor thread retrieval and check Paolo Bonzini (20): unlock iothread during WaitForMultipleObjects implement win32 dynticks timer use win32 timer queues add win32 qemu-thread implementation include qemu-thread.h early add assertions on the owner of a QemuMutex remove CONFIG_THREAD inline cpu_halted into sole caller always qemu_cpu_kick after unhalting a cpu exit round-robin vcpu loop if cpu->stopped is true always signal pause_cond after stopping a VCPU do not use timedwait on qemu_halt_cond do not use timedwait on qemu_system_cond do not use timedwait on qemu_pause_cond do not use timedwait on qemu_cpu_cond iothread stops the vcpu thread via IPI move blocking of signals to qemu_signalfd_init provide dummy signal init functions for win32 protect qemu_cpu_kick_self for Win32 add Win32 IPI service Makefile.objs | 4 +- configure | 2 - cpu-exec.c | 9 +- cpus.c | 298 +++++++++++++++++----------------- exec.c | 2 +- hw/ppc.c | 2 + hw/sun4m.c | 10 +- hw/sun4u.c | 4 +- os-win32.c | 2 + qemu-common.h | 2 +- qemu-thread.c => qemu-thread-posix.c | 38 +++-- qemu-thread-posix.h | 18 ++ qemu-thread-win32.c | 260 +++++++++++++++++++++++++++++ qemu-thread-win32.h | 21 +++ qemu-thread.h | 31 ++-- qemu-timer.c | 89 +++++------ target-alpha/exec.h | 11 -- target-arm/exec.h | 13 -- target-cris/exec.h | 11 -- target-i386/exec.h | 12 -- target-i386/kvm.c | 4 +- target-m68k/exec.h | 10 -- target-microblaze/exec.h | 11 -- target-mips/exec.h | 11 -- target-ppc/exec.h | 11 -- target-s390x/exec.h | 12 -- target-s390x/kvm.c | 1 + target-sh4/cpu.h | 2 +- target-sh4/exec.h | 11 -- target-sh4/helper.c | 4 +- target-sh4/op_helper.c | 1 + target-sparc/exec.h | 10 -- ui/vnc-jobs-async.c | 2 +- 33 files changed, 562 insertions(+), 367 deletions(-) rename qemu-thread.c => qemu-thread-posix.c (81%) create mode 100644 qemu-thread-posix.h create mode 100644 qemu-thread-win32.c create mode 100644 qemu-thread-win32.h -- 1.7.4