From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=45392 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PtzEk-0005xv-OU for qemu-devel@nongnu.org; Mon, 28 Feb 2011 04:17:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ptz8O-0004lF-OL for qemu-devel@nongnu.org; Mon, 28 Feb 2011 04:11:17 -0500 Received: from mail-yx0-f173.google.com ([209.85.213.173]:62213) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ptz8O-0004hM-Ko for qemu-devel@nongnu.org; Mon, 28 Feb 2011 04:11:16 -0500 Received: by mail-yx0-f173.google.com with SMTP id 8so1800210yxk.4 for ; Mon, 28 Feb 2011 01:11:16 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Mon, 28 Feb 2011 10:10:18 +0100 Message-Id: <1298884224-19734-17-git-send-email-pbonzini@redhat.com> In-Reply-To: <1298884224-19734-1-git-send-email-pbonzini@redhat.com> References: <1298884224-19734-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH v3 uq/master 16/22] do not use timedwait on qemu_pause_cond List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: blauwirbel@gmail.com, jan.kiszka@siemes.com, aurelien@aurel32.net, kvm@vger.kernel.org, mtosatti@redhat.com all_vcpus_paused can start returning true after penv->stopped changes from 0 to 1. When this is done, qemu_pause_cond is always signaled. Signed-off-by: Paolo Bonzini --- cpus.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cpus.c b/cpus.c index e367b3b..8f169ad 100644 --- a/cpus.c +++ b/cpus.c @@ -938,7 +938,7 @@ void pause_all_vcpus(void) } while (!all_vcpus_paused()) { - qemu_cond_timedwait(&qemu_pause_cond, &qemu_global_mutex, 100); + qemu_cond_wait(&qemu_pause_cond, &qemu_global_mutex); penv = first_cpu; while (penv) { qemu_cpu_kick(penv); -- 1.7.4