qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: blauwirbel@gmail.com, jan.kiszka@siemes.com,
	aurelien@aurel32.net, kvm@vger.kernel.org, mtosatti@redhat.com
Subject: [Qemu-devel] [PATCH v3 uq/master 22/22] add Win32 IPI service
Date: Mon, 28 Feb 2011 10:10:24 +0100	[thread overview]
Message-ID: <1298884224-19734-23-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1298884224-19734-1-git-send-email-pbonzini@redhat.com>

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 cpus.c              |   25 ++++++++++++++++++++++---
 qemu-thread-posix.c |    9 ---------
 qemu-thread-posix.h |    1 -
 3 files changed, 22 insertions(+), 13 deletions(-)

diff --git a/cpus.c b/cpus.c
index 7559a02..077729c 100644
--- a/cpus.c
+++ b/cpus.c
@@ -854,13 +854,32 @@ static void *qemu_tcg_cpu_thread_fn(void *arg)
     return NULL;
 }
 
+static void qemu_cpu_kick_thread(CPUState *env)
+{
+#ifndef _WIN32
+    int err;
+
+    err = pthread_kill(env->thread->thread, SIG_IPI);
+    if (err) {
+        fprintf(stderr, "qemu:%s: %s", __func__, strerror(err));
+        exit(1);
+    }
+#else /* _WIN32 */
+    if (!qemu_cpu_is_self(env)) {
+        SuspendThread(env->thread->thread);
+        cpu_signal(0);
+        ResumeThread(env->thread->thread);
+    }
+#endif
+}
+
 void qemu_cpu_kick(void *_env)
 {
     CPUState *env = _env;
 
     qemu_cond_broadcast(env->halt_cond);
     if (!env->thread_kicked) {
-        qemu_thread_signal(env->thread, SIG_IPI);
+        qemu_cpu_kick_thread(env);
         env->thread_kicked = true;
     }
 }
@@ -871,7 +890,7 @@ void qemu_cpu_kick_self(void)
     assert(cpu_single_env);
 
     if (!cpu_single_env->thread_kicked) {
-        qemu_thread_signal(cpu_single_env->thread, SIG_IPI);
+        qemu_cpu_kick_thread(cpu_single_env);
         cpu_single_env->thread_kicked = true;
     }
 #else
@@ -893,7 +912,7 @@ void qemu_mutex_lock_iothread(void)
     } else {
         qemu_mutex_lock(&qemu_fair_mutex);
         if (qemu_mutex_trylock(&qemu_global_mutex)) {
-            qemu_thread_signal(tcg_cpu_thread, SIG_IPI);
+            qemu_cpu_kick_thread(first_cpu);
             qemu_mutex_lock(&qemu_global_mutex);
         }
         qemu_mutex_unlock(&qemu_fair_mutex);
diff --git a/qemu-thread-posix.c b/qemu-thread-posix.c
index a4c6e25..9cceda7 100644
--- a/qemu-thread-posix.c
+++ b/qemu-thread-posix.c
@@ -186,15 +186,6 @@ void qemu_thread_create(QemuThread *thread,
     pthread_sigmask(SIG_SETMASK, &oldset, NULL);
 }
 
-void qemu_thread_signal(QemuThread *thread, int sig)
-{
-    int err;
-
-    err = pthread_kill(thread->thread, sig);
-    if (err)
-        error_exit(err, __func__);
-}
-
 void qemu_thread_get_self(QemuThread *thread)
 {
     thread->thread = pthread_self();
diff --git a/qemu-thread-posix.h b/qemu-thread-posix.h
index 11978db..35e0a8b 100644
--- a/qemu-thread-posix.h
+++ b/qemu-thread-posix.h
@@ -15,5 +15,4 @@ struct QemuThread {
     pthread_t thread;
 };
 
-void qemu_thread_signal(QemuThread *thread, int sig);
 #endif
-- 
1.7.4

  parent reply	other threads:[~2011-02-28  9:17 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-28  9:10 [Qemu-devel] [PATCH v3 uq/master 00/22] Win32 iothread support Paolo Bonzini
2011-02-28  9:10 ` [Qemu-devel] [PATCH v3 uq/master 01/22] unlock iothread during WaitForMultipleObjects Paolo Bonzini
2011-02-28  9:10 ` [Qemu-devel] [PATCH v3 uq/master 02/22] implement win32 dynticks timer Paolo Bonzini
2011-02-28  9:10 ` [Qemu-devel] [PATCH v3 uq/master 03/22] use win32 timer queues Paolo Bonzini
2011-02-28  9:10 ` [Qemu-devel] [PATCH v3 uq/master 04/22] Refactor thread retrieval and check Paolo Bonzini
2011-02-28  9:10 ` [Qemu-devel] [PATCH v3 uq/master 05/22] add win32 qemu-thread implementation Paolo Bonzini
2011-02-28  9:33   ` [Qemu-devel] " Stefan Hajnoczi
2011-02-28 10:14     ` [Qemu-devel] [PATCH v4 uq/master] " Paolo Bonzini
2011-02-28  9:10 ` [Qemu-devel] [PATCH v3 uq/master 06/22] include qemu-thread.h early Paolo Bonzini
2011-02-28  9:10 ` [Qemu-devel] [PATCH v3 uq/master 07/22] add assertions on the owner of a QemuMutex Paolo Bonzini
2011-02-28  9:10 ` [Qemu-devel] [PATCH v3 uq/master 08/22] remove CONFIG_THREAD Paolo Bonzini
2011-02-28  9:10 ` [Qemu-devel] [PATCH v3 uq/master 09/22] target-sh4: move intr_at_halt out of cpu_halted() Paolo Bonzini
2011-02-28  9:10 ` [Qemu-devel] [PATCH v3 uq/master 10/22] inline cpu_halted into sole caller Paolo Bonzini
2011-02-28  9:10 ` [Qemu-devel] [PATCH v3 uq/master 11/22] always qemu_cpu_kick after unhalting a cpu Paolo Bonzini
2011-02-28  9:10 ` [Qemu-devel] [PATCH v3 uq/master 12/22] exit round-robin vcpu loop if cpu->stopped is true Paolo Bonzini
2011-02-28  9:10 ` [Qemu-devel] [PATCH v3 uq/master 13/22] always signal pause_cond after stopping a VCPU Paolo Bonzini
2011-02-28  9:10 ` [Qemu-devel] [PATCH v3 uq/master 14/22] do not use timedwait on qemu_halt_cond Paolo Bonzini
2011-02-28  9:10 ` [Qemu-devel] [PATCH v3 uq/master 15/22] do not use timedwait on qemu_system_cond Paolo Bonzini
2011-02-28  9:10 ` [Qemu-devel] [PATCH v3 uq/master 16/22] do not use timedwait on qemu_pause_cond Paolo Bonzini
2011-02-28  9:10 ` [Qemu-devel] [PATCH v3 uq/master 17/22] do not use timedwait on qemu_cpu_cond Paolo Bonzini
2011-02-28  9:10 ` [Qemu-devel] [PATCH v3 uq/master 18/22] iothread stops the vcpu thread via IPI Paolo Bonzini
2011-02-28  9:10 ` [Qemu-devel] [PATCH v3 uq/master 19/22] merge all signal initialization with qemu_signalfd_init, rename Paolo Bonzini
2011-02-28  9:10 ` [Qemu-devel] [PATCH v3 uq/master 20/22] provide dummy signal init functions for win32 Paolo Bonzini
2011-02-28  9:10 ` [Qemu-devel] [PATCH v3 uq/master 21/22] protect qemu_cpu_kick_self for Win32 Paolo Bonzini
2011-02-28  9:10 ` Paolo Bonzini [this message]
2011-02-28  9:16 ` [Qemu-devel] Re: [PATCH v3 uq/master 00/22] Win32 iothread support Avi Kivity
2011-02-28 10:10   ` Paolo Bonzini
2011-02-28 11:57     ` Jan Kiszka
2011-02-28 12:13       ` Avi Kivity
2011-02-28 14:05         ` Paolo Bonzini
2011-03-01 12:35           ` Avi Kivity
2011-03-02 18:43             ` Marcelo Tosatti
2011-03-02 19:03               ` Jan Kiszka
2011-03-02 19:36                 ` Marcelo Tosatti
2011-03-02 19:42                   ` Marcelo Tosatti
2011-03-03  8:48                     ` Avi Kivity
2011-03-03  9:07                       ` Jan Kiszka
2011-03-03  9:12                         ` Avi Kivity
2011-03-03  9:13                         ` Paolo Bonzini
2011-03-03  9:28                           ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1298884224-19734-23-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aurelien@aurel32.net \
    --cc=blauwirbel@gmail.com \
    --cc=jan.kiszka@siemes.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).