From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35530 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pu1Bo-0005Di-N6 for qemu-devel@nongnu.org; Mon, 28 Feb 2011 06:23:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pu1Be-0007N3-3v for qemu-devel@nongnu.org; Mon, 28 Feb 2011 06:22:48 -0500 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:60183) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pu1Bd-0007Mn-If for qemu-devel@nongnu.org; Mon, 28 Feb 2011 06:22:46 -0500 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [202.81.31.246]) by e23smtp07.au.ibm.com (8.14.4/8.13.1) with ESMTP id p1SBMiNt014936 for ; Mon, 28 Feb 2011 22:22:44 +1100 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p1SBMiv11859814 for ; Mon, 28 Feb 2011 22:22:44 +1100 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p1SBMhqK032647 for ; Mon, 28 Feb 2011 22:22:44 +1100 From: "M. Mohan Kumar" Date: Mon, 28 Feb 2011 16:52:32 +0530 Message-Id: <1298892156-11667-6-git-send-email-mohan@in.ibm.com> In-Reply-To: <1298892156-11667-1-git-send-email-mohan@in.ibm.com> References: <1298892156-11667-1-git-send-email-mohan@in.ibm.com> Subject: [Qemu-devel] [V6 PATCH 5/9] virtio-9p: Add support to open a file in chroot environment List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Stefan Hajnoczi This patch adds both chroot deamon and qemu side support to open a file/ directory in the chroot environment Signed-off-by: M. Mohan Kumar --- hw/9pfs/virtio-9p-chroot-qemu.c | 24 +++++++++++----- hw/9pfs/virtio-9p-chroot.h | 2 +- hw/9pfs/virtio-9p-local.c | 58 ++++++++++++++++++++++++++++++++++++--- 3 files changed, 71 insertions(+), 13 deletions(-) diff --git a/hw/9pfs/virtio-9p-chroot-qemu.c b/hw/9pfs/virtio-9p-chroot-qemu.c index d2d8ab9..41f9db2 100644 --- a/hw/9pfs/virtio-9p-chroot-qemu.c +++ b/hw/9pfs/virtio-9p-chroot-qemu.c @@ -85,13 +85,21 @@ static int v9fs_write_request(int sockfd, V9fsFileObjectRequest *request) return 0; } -/* - * This patch adds v9fs_receivefd and v9fs_write_request functions, - * but there is no callers. To avoid compiler warning message, - * refer these two functions - */ -void chroot_dummy(void) +/* Return opened file descriptor on success or -errno on error */ +int v9fs_request(FsContext *fs_ctx, V9fsFileObjectRequest *request) { - (void)v9fs_receivefd; - (void)v9fs_write_request; + int fd, sock_error; + qemu_mutex_lock(&fs_ctx->chroot_mutex); + if (fs_ctx->chroot_ioerror) { + fd = -EIO; + goto unlock; + } + v9fs_write_request(fs_ctx->chroot_socket, request); + fd = v9fs_receivefd(fs_ctx->chroot_socket, &sock_error); + if (fd < 0 && sock_error) { + fs_ctx->chroot_ioerror = 1; + } +unlock: + qemu_mutex_unlock(&fs_ctx->chroot_mutex); + return fd; } diff --git a/hw/9pfs/virtio-9p-chroot.h b/hw/9pfs/virtio-9p-chroot.h index bd186dd..4592807 100644 --- a/hw/9pfs/virtio-9p-chroot.h +++ b/hw/9pfs/virtio-9p-chroot.h @@ -53,6 +53,6 @@ typedef struct V9fsFileObjectRequest } V9fsFileObjectRequest; int v9fs_chroot(FsContext *fs_ctx); -void chroot_dummy(void); +int v9fs_request(FsContext *fs_ctx, V9fsFileObjectRequest *or); #endif /* _QEMU_VIRTIO_9P_CHROOT_H */ diff --git a/hw/9pfs/virtio-9p-local.c b/hw/9pfs/virtio-9p-local.c index 0a015de..0c55d35 100644 --- a/hw/9pfs/virtio-9p-local.c +++ b/hw/9pfs/virtio-9p-local.c @@ -13,6 +13,9 @@ #include "virtio.h" #include "virtio-9p.h" #include "virtio-9p-xattr.h" +#include "qemu_socket.h" +#include "fsdev/qemu-fsdev.h" +#include "virtio-9p-chroot.h" #include #include #include @@ -20,6 +23,40 @@ #include #include +/* Helper routine to fill V9fsFileObjectRequest structure */ +static int fill_fileobjectrequest(V9fsFileObjectRequest *request, + const char *path, FsCred *credp) +{ + if (strlen(path) > PATH_MAX) { + return -ENAMETOOLONG; + } + memset(request, 0, sizeof(*request)); + request->data.path_len = strlen(path); + strcpy(request->path.path, path); + if (credp) { + request->data.mode = credp->fc_mode; + request->data.uid = credp->fc_uid; + request->data.gid = credp->fc_gid; + request->data.dev = credp->fc_rdev; + } + return 0; +} + +static int passthrough_open(FsContext *fs_ctx, const char *path, int flags) +{ + V9fsFileObjectRequest request; + int fd; + + fd = fill_fileobjectrequest(&request, path, NULL); + if (fd < 0) { + errno = -fd; + return -1; + } + request.data.flags = flags; + request.data.type = T_OPEN; + fd = v9fs_request(fs_ctx, &request); + return fd; +} static int local_lstat(FsContext *fs_ctx, const char *path, struct stat *stbuf) { @@ -138,14 +175,27 @@ static int local_closedir(FsContext *ctx, DIR *dir) return closedir(dir); } -static int local_open(FsContext *ctx, const char *path, int flags) +static int local_open(FsContext *fs_ctx, const char *path, int flags) { - return open(rpath(ctx, path), flags); + if (fs_ctx->fs_sm == SM_PASSTHROUGH) { + return passthrough_open(fs_ctx, path, flags); + } else { + return open(rpath(fs_ctx, path), flags); + } } -static DIR *local_opendir(FsContext *ctx, const char *path) +static DIR *local_opendir(FsContext *fs_ctx, const char *path) { - return opendir(rpath(ctx, path)); + if (fs_ctx->fs_sm == SM_PASSTHROUGH) { + int fd; + fd = passthrough_open(fs_ctx, path, O_DIRECTORY); + if (fd < 0) { + return NULL; + } + return fdopendir(fd); + } else { + return opendir(rpath(fs_ctx, path)); + } } static void local_rewinddir(FsContext *ctx, DIR *dir) -- 1.7.3.4