qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH -V3 4/8] hw/9pfs: Implement syncfs
Date: Sat,  5 Mar 2011 23:22:09 +0530	[thread overview]
Message-ID: <1299347533-17047-4-git-send-email-aneesh.kumar@linux.vnet.ibm.com> (raw)
In-Reply-To: <1299347533-17047-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>

SYNOPSIS
    size[4] Tsyncfs tag[2] fid[4]

    size[4] Rsyncfs tag[2]

DESCRIPTION
    The Tsyncfs transaction transfers ("flushes") all modified data of
    file system identified by fid to the disk device. The operation is
    equivalent to calling sync() on the file system.

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
 hw/9pfs/virtio-9p-local.c |    9 +++++++++
 hw/9pfs/virtio-9p.c       |   31 +++++++++++++++++++++++++++++++
 hw/9pfs/virtio-9p.h       |    2 ++
 hw/file-op-9p.h           |    1 +
 4 files changed, 43 insertions(+), 0 deletions(-)

diff --git a/hw/9pfs/virtio-9p-local.c b/hw/9pfs/virtio-9p-local.c
index 0a015de..43ff37c 100644
--- a/hw/9pfs/virtio-9p-local.c
+++ b/hw/9pfs/virtio-9p-local.c
@@ -528,6 +528,14 @@ static int local_lremovexattr(FsContext *ctx,
     return v9fs_remove_xattr(ctx, path, name);
 }
 
+static int local_syncfs(FsContext *ctx, int fd)
+{
+    /*
+     * We should be doing per file system sync here.
+     */
+    sync();
+    return 0;
+}
 
 FileOperations local_ops = {
     .lstat = local_lstat,
@@ -560,4 +568,5 @@ FileOperations local_ops = {
     .llistxattr = local_llistxattr,
     .lsetxattr = local_lsetxattr,
     .lremovexattr = local_lremovexattr,
+    .syncfs     = local_syncfs,
 };
diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
index c4b0198..ce09e55 100644
--- a/hw/9pfs/virtio-9p.c
+++ b/hw/9pfs/virtio-9p.c
@@ -299,6 +299,10 @@ static int v9fs_do_lremovexattr(V9fsState *s, V9fsString *path,
                                 xattr_name->data);
 }
 
+static int v9fs_do_syncfs(V9fsState *s, int fd)
+{
+    return s->ops->syncfs(&s->ctx, fd);
+}
 
 static void v9fs_string_init(V9fsString *str)
 {
@@ -1978,6 +1982,32 @@ static void v9fs_fsync(V9fsState *s, V9fsPDU *pdu)
     v9fs_post_do_fsync(s, pdu, err);
 }
 
+static void v9fs_post_do_syncfs(V9fsState *s, V9fsPDU *pdu, int err)
+{
+    if (err == -1) {
+        err = -errno;
+    }
+    complete_pdu(s, pdu, err);
+}
+
+static void v9fs_syncfs(V9fsState *s, V9fsPDU *pdu)
+{
+    int err;
+    int32_t fid;
+    size_t offset = 7;
+    V9fsFidState *fidp;
+
+    pdu_unmarshal(pdu, offset, "d", &fid);
+    fidp = lookup_fid(s, fid);
+    if (fidp == NULL) {
+        err = -ENOENT;
+        v9fs_post_do_syncfs(s, pdu, err);
+        return;
+    }
+    err = v9fs_do_syncfs(s, fidp->fsmap.fs.fd);
+    v9fs_post_do_syncfs(s, pdu, err);
+}
+
 static void v9fs_clunk(V9fsState *s, V9fsPDU *pdu)
 {
     int32_t fid;
@@ -3676,6 +3706,7 @@ static pdu_handler_t *pdu_handlers[] = {
     [P9_TWALK] = v9fs_walk,
     [P9_TCLUNK] = v9fs_clunk,
     [P9_TFSYNC] = v9fs_fsync,
+    [P9_TSYNCFS] = v9fs_syncfs,
     [P9_TOPEN] = v9fs_open,
     [P9_TREAD] = v9fs_read,
 #if 0
diff --git a/hw/9pfs/virtio-9p.h b/hw/9pfs/virtio-9p.h
index 68d5906..b0f8210 100644
--- a/hw/9pfs/virtio-9p.h
+++ b/hw/9pfs/virtio-9p.h
@@ -13,6 +13,8 @@
 #define VIRTIO_9P_MOUNT_TAG 0
 
 enum {
+    P9_TSYNCFS = 0,
+    P9_RSYNCFS,
     P9_TLERROR = 6,
     P9_RLERROR,
     P9_TSTATFS = 8,
diff --git a/hw/file-op-9p.h b/hw/file-op-9p.h
index 126e60e..e306305 100644
--- a/hw/file-op-9p.h
+++ b/hw/file-op-9p.h
@@ -94,6 +94,7 @@ typedef struct FileOperations
     int (*lsetxattr)(FsContext *, const char *,
                      const char *, void *, size_t, int);
     int (*lremovexattr)(FsContext *, const char *, const char *);
+    int (*syncfs)(FsContext *, int);
     void *opaque;
 } FileOperations;
 
-- 
1.7.1

  parent reply	other threads:[~2011-03-05 17:52 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-05 17:52 [Qemu-devel] [PATCH -V3 1/8] hw/9pfs: Add V9fsfidmap in preparation for adding fd reclaim Aneesh Kumar K.V
2011-03-05 17:52 ` [Qemu-devel] [PATCH -V3 2/8] hw/9pfs: Add file descriptor reclaim support Aneesh Kumar K.V
2011-03-13 16:08   ` Stefan Hajnoczi
2011-03-13 18:57     ` Aneesh Kumar K. V
2011-03-14 10:13       ` Stefan Hajnoczi
2011-03-15  8:35         ` Aneesh Kumar K. V
2011-03-05 17:52 ` [Qemu-devel] [PATCH -V3 3/8] hw/9pfs: Use v9fs_do_close instead of close Aneesh Kumar K.V
2011-03-13 16:10   ` Stefan Hajnoczi
2011-03-13 18:58     ` Aneesh Kumar K. V
2011-03-05 17:52 ` Aneesh Kumar K.V [this message]
2011-03-13 16:24   ` [Qemu-devel] [PATCH -V3 4/8] hw/9pfs: Implement syncfs Stefan Hajnoczi
2011-03-13 18:59     ` Aneesh Kumar K. V
2011-03-05 17:52 ` [Qemu-devel] [PATCH -V3 5/8] hw/9pfs: Add open flag to fid Aneesh Kumar K.V
2011-03-13 16:38   ` Stefan Hajnoczi
2011-03-13 19:01     ` Aneesh Kumar K. V
2011-03-05 17:52 ` [Qemu-devel] [PATCH -V3 6/8] hw/9pfs: Add directory reclaim support Aneesh Kumar K.V
2011-03-13 16:42   ` Stefan Hajnoczi
2011-03-13 19:02     ` Aneesh Kumar K. V
2011-03-05 17:52 ` [Qemu-devel] [PATCH -V3 7/8] hw/9pfs: Add new virtfs option cache=none to skip host page cache Aneesh Kumar K.V
2011-03-13 17:23   ` Stefan Hajnoczi
2011-03-13 19:04     ` Aneesh Kumar K. V
2011-03-13 20:57       ` Stefan Hajnoczi
2011-03-15  8:36         ` Aneesh Kumar K. V
2011-03-14 10:20       ` Stefan Hajnoczi
2011-03-15  9:19         ` Aneesh Kumar K. V
2011-03-15 11:11           ` Stefan Hajnoczi
2011-03-15 12:30             ` Aneesh Kumar K. V
2011-03-16  8:59               ` Stefan Hajnoczi
2011-03-05 17:52 ` [Qemu-devel] [PATCH -V3 8/8] hw/9pfs: Skip file system sync if we have specified cache=none option Aneesh Kumar K.V
2011-03-13 15:46 ` [Qemu-devel] [PATCH -V3 1/8] hw/9pfs: Add V9fsfidmap in preparation for adding fd reclaim Stefan Hajnoczi
2011-03-13 19:06   ` Aneesh Kumar K. V
2011-03-13 20:53     ` Stefan Hajnoczi
2011-03-14 10:23       ` Stefan Hajnoczi
2011-03-15  9:20       ` Aneesh Kumar K. V
2011-03-15 10:38         ` Stefan Hajnoczi
2011-03-15 12:27           ` Aneesh Kumar K. V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299347533-17047-4-git-send-email-aneesh.kumar@linux.vnet.ibm.com \
    --to=aneesh.kumar@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).