* [Qemu-devel] [PATCH] target-arm: Fix TCG temporary leaks for scalar VMULL
@ 2011-03-11 13:32 Peter Maydell
2011-03-22 6:58 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Peter Maydell @ 2011-03-11 13:32 UTC (permalink / raw)
To: qemu-devel; +Cc: patches
Fix a TCG temporary leak when translating 32-bit scalar VMULL.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
This was found by the TCG leak-checking support that was committed a
little while back. Score one for debug code :-)
target-arm/translate.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/target-arm/translate.c b/target-arm/translate.c
index 062de5e..e8ec987 100644
--- a/target-arm/translate.c
+++ b/target-arm/translate.c
@@ -4157,10 +4157,12 @@ static inline void gen_neon_mull(TCGv_i64 dest, TCGv a, TCGv b, int size, int u)
case 4:
tmp = gen_muls_i64_i32(a, b);
tcg_gen_mov_i64(dest, tmp);
+ tcg_temp_free_i64(tmp);
break;
case 5:
tmp = gen_mulu_i64_i32(a, b);
tcg_gen_mov_i64(dest, tmp);
+ tcg_temp_free_i64(tmp);
break;
default: abort();
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] target-arm: Fix TCG temporary leaks for scalar VMULL
2011-03-11 13:32 [Qemu-devel] [PATCH] target-arm: Fix TCG temporary leaks for scalar VMULL Peter Maydell
@ 2011-03-22 6:58 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2011-03-22 6:58 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-devel, patches
On Fri, Mar 11, 2011 at 01:32:34PM +0000, Peter Maydell wrote:
> Fix a TCG temporary leak when translating 32-bit scalar VMULL.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> This was found by the TCG leak-checking support that was committed a
> little while back. Score one for debug code :-)
>
> target-arm/translate.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
Thanks, applied.
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index 062de5e..e8ec987 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -4157,10 +4157,12 @@ static inline void gen_neon_mull(TCGv_i64 dest, TCGv a, TCGv b, int size, int u)
> case 4:
> tmp = gen_muls_i64_i32(a, b);
> tcg_gen_mov_i64(dest, tmp);
> + tcg_temp_free_i64(tmp);
> break;
> case 5:
> tmp = gen_mulu_i64_i32(a, b);
> tcg_gen_mov_i64(dest, tmp);
> + tcg_temp_free_i64(tmp);
> break;
> default: abort();
> }
> --
> 1.7.1
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-22 7:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-11 13:32 [Qemu-devel] [PATCH] target-arm: Fix TCG temporary leaks for scalar VMULL Peter Maydell
2011-03-22 6:58 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).