qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: patches@linaro.org
Subject: [Qemu-devel] [PATCH 7/7] target-arm: Use new softfloat min/max functions for VMAX, VMIN
Date: Fri, 11 Mar 2011 18:12:26 +0000	[thread overview]
Message-ID: <1299867146-22049-8-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1299867146-22049-1-git-send-email-peter.maydell@linaro.org>

Use the new softfloat min/max functions to implement the Neon VMAX
and VMIN instructions. This allows us to get the right behaviour
for NaN and negative zero.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target-arm/neon_helper.c |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c
index 1905545..19784ab 100644
--- a/target-arm/neon_helper.c
+++ b/target-arm/neon_helper.c
@@ -1772,16 +1772,12 @@ uint32_t HELPER(neon_qneg_s32)(CPUState *env, uint32_t x)
 /* NEON Float helpers.  */
 uint32_t HELPER(neon_min_f32)(CPUState *env, uint32_t a, uint32_t b)
 {
-    float32 f0 = make_float32(a);
-    float32 f1 = make_float32(b);
-    return (float32_compare_quiet(f0, f1, NFS) == -1) ? a : b;
+    return float32_val(float32_min(make_float32(a), make_float32(b), NFS));
 }
 
 uint32_t HELPER(neon_max_f32)(CPUState *env, uint32_t a, uint32_t b)
 {
-    float32 f0 = make_float32(a);
-    float32 f1 = make_float32(b);
-    return (float32_compare_quiet(f0, f1, NFS) == 1) ? a : b;
+    return float32_val(float32_max(make_float32(a), make_float32(b), NFS));
 }
 
 uint32_t HELPER(neon_abd_f32)(CPUState *env, uint32_t a, uint32_t b)
-- 
1.7.1

      parent reply	other threads:[~2011-03-11 18:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-11 18:12 [Qemu-devel] [PATCH 0/7] ARM: minor Neon fixes (mostly NaN related) Peter Maydell
2011-03-11 18:12 ` [Qemu-devel] [PATCH 1/7] target-arm: Make Neon helper routines use correct FP status Peter Maydell
2011-03-11 18:30   ` Nathan Froyd
2011-03-11 22:31     ` Peter Maydell
2011-03-14  5:35       ` Nathan Froyd
2011-03-28 14:15         ` Peter Maydell
2011-03-30 18:38           ` Nathan Froyd
2011-03-11 18:12 ` [Qemu-devel] [PATCH 2/7] target-arm/neon_helper.c: Use make_float32/float32_val macros Peter Maydell
2011-03-11 18:29   ` Nathan Froyd
2011-03-11 18:12 ` [Qemu-devel] [PATCH 3/7] target-arm: Return right result for Neon comparison with NaNs Peter Maydell
2011-03-11 18:12 ` [Qemu-devel] [PATCH 4/7] target-arm: Fix VCLE.F32 #0, VCLT.F32 #0 NaN handling Peter Maydell
2011-03-11 18:12 ` [Qemu-devel] [PATCH 5/7] target-arm: Correct ABD's handling of negative zeroes Peter Maydell
2011-03-11 18:12 ` [Qemu-devel] [PATCH 6/7] softfloat: Add float*_min() and float*_max() functions Peter Maydell
2011-03-11 18:28   ` Nathan Froyd
2011-03-11 23:31     ` Peter Maydell
2011-03-11 18:12 ` Peter Maydell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299867146-22049-8-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=patches@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).