From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=46820 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Py6pJ-0002vc-PR for qemu-devel@nongnu.org; Fri, 11 Mar 2011 13:12:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Py6pI-0005nG-Et for qemu-devel@nongnu.org; Fri, 11 Mar 2011 13:12:37 -0500 Received: from mnementh.archaic.org.uk ([81.2.115.146]:53506) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Py6pI-0005kF-6L for qemu-devel@nongnu.org; Fri, 11 Mar 2011 13:12:36 -0500 From: Peter Maydell Date: Fri, 11 Mar 2011 18:12:26 +0000 Message-Id: <1299867146-22049-8-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1299867146-22049-1-git-send-email-peter.maydell@linaro.org> References: <1299867146-22049-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH 7/7] target-arm: Use new softfloat min/max functions for VMAX, VMIN List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: patches@linaro.org Use the new softfloat min/max functions to implement the Neon VMAX and VMIN instructions. This allows us to get the right behaviour for NaN and negative zero. Signed-off-by: Peter Maydell --- target-arm/neon_helper.c | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c index 1905545..19784ab 100644 --- a/target-arm/neon_helper.c +++ b/target-arm/neon_helper.c @@ -1772,16 +1772,12 @@ uint32_t HELPER(neon_qneg_s32)(CPUState *env, uint32_t x) /* NEON Float helpers. */ uint32_t HELPER(neon_min_f32)(CPUState *env, uint32_t a, uint32_t b) { - float32 f0 = make_float32(a); - float32 f1 = make_float32(b); - return (float32_compare_quiet(f0, f1, NFS) == -1) ? a : b; + return float32_val(float32_min(make_float32(a), make_float32(b), NFS)); } uint32_t HELPER(neon_max_f32)(CPUState *env, uint32_t a, uint32_t b) { - float32 f0 = make_float32(a); - float32 f1 = make_float32(b); - return (float32_compare_quiet(f0, f1, NFS) == 1) ? a : b; + return float32_val(float32_max(make_float32(a), make_float32(b), NFS)); } uint32_t HELPER(neon_abd_f32)(CPUState *env, uint32_t a, uint32_t b) -- 1.7.1