From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: blauwirbel@gmail.com
Subject: [Qemu-devel] [PATCH v4 upstream 21/21] add Win32 IPI service
Date: Sat, 12 Mar 2011 17:44:08 +0100 [thread overview]
Message-ID: <1299948248-30206-22-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1299948248-30206-1-git-send-email-pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
cpus.c | 25 ++++++++++++++++++++++---
qemu-thread-posix.c | 9 ---------
qemu-thread-posix.h | 1 -
3 files changed, 22 insertions(+), 13 deletions(-)
diff --git a/cpus.c b/cpus.c
index 7559a02..077729c 100644
--- a/cpus.c
+++ b/cpus.c
@@ -854,13 +854,32 @@ static void *qemu_tcg_cpu_thread_fn(void *arg)
return NULL;
}
+static void qemu_cpu_kick_thread(CPUState *env)
+{
+#ifndef _WIN32
+ int err;
+
+ err = pthread_kill(env->thread->thread, SIG_IPI);
+ if (err) {
+ fprintf(stderr, "qemu:%s: %s", __func__, strerror(err));
+ exit(1);
+ }
+#else /* _WIN32 */
+ if (!qemu_cpu_is_self(env)) {
+ SuspendThread(env->thread->thread);
+ cpu_signal(0);
+ ResumeThread(env->thread->thread);
+ }
+#endif
+}
+
void qemu_cpu_kick(void *_env)
{
CPUState *env = _env;
qemu_cond_broadcast(env->halt_cond);
if (!env->thread_kicked) {
- qemu_thread_signal(env->thread, SIG_IPI);
+ qemu_cpu_kick_thread(env);
env->thread_kicked = true;
}
}
@@ -871,7 +890,7 @@ void qemu_cpu_kick_self(void)
assert(cpu_single_env);
if (!cpu_single_env->thread_kicked) {
- qemu_thread_signal(cpu_single_env->thread, SIG_IPI);
+ qemu_cpu_kick_thread(cpu_single_env);
cpu_single_env->thread_kicked = true;
}
#else
@@ -893,7 +912,7 @@ void qemu_mutex_lock_iothread(void)
} else {
qemu_mutex_lock(&qemu_fair_mutex);
if (qemu_mutex_trylock(&qemu_global_mutex)) {
- qemu_thread_signal(tcg_cpu_thread, SIG_IPI);
+ qemu_cpu_kick_thread(first_cpu);
qemu_mutex_lock(&qemu_global_mutex);
}
qemu_mutex_unlock(&qemu_fair_mutex);
diff --git a/qemu-thread-posix.c b/qemu-thread-posix.c
index 8b54cc0..87c1a9f 100644
--- a/qemu-thread-posix.c
+++ b/qemu-thread-posix.c
@@ -171,15 +171,6 @@ void qemu_thread_create(QemuThread *thread,
pthread_sigmask(SIG_SETMASK, &oldset, NULL);
}
-void qemu_thread_signal(QemuThread *thread, int sig)
-{
- int err;
-
- err = pthread_kill(thread->thread, sig);
- if (err)
- error_exit(err, __func__);
-}
-
void qemu_thread_get_self(QemuThread *thread)
{
thread->thread = pthread_self();
diff --git a/qemu-thread-posix.h b/qemu-thread-posix.h
index 7af371c..ee4618e 100644
--- a/qemu-thread-posix.h
+++ b/qemu-thread-posix.h
@@ -14,5 +14,4 @@ struct QemuThread {
pthread_t thread;
};
-void qemu_thread_signal(QemuThread *thread, int sig);
#endif
--
1.7.4
next prev parent reply other threads:[~2011-03-12 16:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-12 16:43 [Qemu-devel] [PATCH v4 upstream 00/21] Win32 iothread support Paolo Bonzini
2011-03-12 16:43 ` [Qemu-devel] [PATCH v4 upstream 01/21] unlock iothread during WaitForMultipleObjects Paolo Bonzini
2011-03-12 16:43 ` [Qemu-devel] [PATCH v4 upstream 02/21] implement win32 dynticks timer Paolo Bonzini
2011-03-12 16:43 ` [Qemu-devel] [PATCH v4 upstream 03/21] use win32 timer queues Paolo Bonzini
2011-03-12 16:43 ` [Qemu-devel] [PATCH v4 upstream 04/21] Refactor thread retrieval and check Paolo Bonzini
2011-03-12 16:43 ` [Qemu-devel] [PATCH v4 upstream 05/21] add win32 qemu-thread implementation Paolo Bonzini
2011-03-12 16:43 ` [Qemu-devel] [PATCH v4 upstream 06/21] include qemu-thread.h early Paolo Bonzini
2011-03-12 16:43 ` [Qemu-devel] [PATCH v4 upstream 07/21] add assertions on the owner of a QemuMutex Paolo Bonzini
2011-03-12 16:43 ` [Qemu-devel] [PATCH v4 upstream 08/21] remove CONFIG_THREAD Paolo Bonzini
2011-03-12 16:43 ` [Qemu-devel] [PATCH v4 upstream 09/21] inline cpu_halted into sole caller Paolo Bonzini
2011-03-12 16:43 ` [Qemu-devel] [PATCH v4 upstream 10/21] always qemu_cpu_kick after unhalting a cpu Paolo Bonzini
2011-03-12 16:43 ` [Qemu-devel] [PATCH v4 upstream 11/21] exit round-robin vcpu loop if cpu->stopped is true Paolo Bonzini
2011-03-12 16:43 ` [Qemu-devel] [PATCH v4 upstream 12/21] always signal pause_cond after stopping a VCPU Paolo Bonzini
2011-03-12 16:44 ` [Qemu-devel] [PATCH v4 upstream 13/21] do not use timedwait on qemu_halt_cond Paolo Bonzini
2011-03-12 16:44 ` [Qemu-devel] [PATCH v4 upstream 14/21] do not use timedwait on qemu_system_cond Paolo Bonzini
2011-03-12 16:44 ` [Qemu-devel] [PATCH v4 upstream 15/21] do not use timedwait on qemu_pause_cond Paolo Bonzini
2011-03-12 16:44 ` [Qemu-devel] [PATCH v4 upstream 16/21] do not use timedwait on qemu_cpu_cond Paolo Bonzini
2011-03-12 16:44 ` [Qemu-devel] [PATCH v4 upstream 17/21] iothread stops the vcpu thread via IPI Paolo Bonzini
2011-03-12 16:44 ` [Qemu-devel] [PATCH v4 upstream 18/21] merge all signal initialization with qemu_signalfd_init, rename Paolo Bonzini
2011-03-12 16:44 ` [Qemu-devel] [PATCH v4 upstream 19/21] provide dummy signal init functions for win32 Paolo Bonzini
2011-03-12 16:44 ` [Qemu-devel] [PATCH v4 upstream 20/21] protect qemu_cpu_kick_self for Win32 Paolo Bonzini
2011-03-12 16:44 ` Paolo Bonzini [this message]
2011-03-13 14:45 ` [Qemu-devel] Re: [PATCH v4 upstream 00/21] Win32 iothread support Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299948248-30206-22-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).