qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [RFC PATCH 5/5] remove qemu_get_clock
Date: Sat, 12 Mar 2011 18:04:20 +0100	[thread overview]
Message-ID: <1299949460-4387-6-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1299949460-4387-1-git-send-email-pbonzini@redhat.com>

These patches are already not doing a great service to out-of-tree
modifications to QEMU.  However, at least we can warn them by getting
rid of the old confusing functions, or otherwise causing compilation
errors.  This patch removes qemu_get_clock; the previous one changed
qemu_new_timer's signature.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 qemu-timer.c |   17 -----------------
 qemu-timer.h |    1 -
 2 files changed, 0 insertions(+), 18 deletions(-)

diff --git a/qemu-timer.c b/qemu-timer.c
index 1aed535..f6e059f 100644
--- a/qemu-timer.c
+++ b/qemu-timer.c
@@ -511,23 +511,6 @@ static void qemu_run_timers(QEMUClock *clock)
     }
 }
 
-int64_t qemu_get_clock(QEMUClock *clock)
-{
-    switch(clock->type) {
-    case QEMU_CLOCK_REALTIME:
-        return get_clock() / 1000000;
-    default:
-    case QEMU_CLOCK_VIRTUAL:
-        if (use_icount) {
-            return cpu_get_icount();
-        } else {
-            return cpu_get_clock();
-        }
-    case QEMU_CLOCK_HOST:
-        return get_clock_realtime();
-    }
-}
-
 int64_t qemu_get_clock_ns(QEMUClock *clock)
 {
     switch(clock->type) {
diff --git a/qemu-timer.h b/qemu-timer.h
index 0ea77fb..75d5675 100644
--- a/qemu-timer.h
+++ b/qemu-timer.h
@@ -37,7 +37,6 @@ extern QEMUClock *vm_clock;
    the virtual clock. */
 extern QEMUClock *host_clock;
 
-int64_t qemu_get_clock(QEMUClock *clock);
 int64_t qemu_get_clock_ns(QEMUClock *clock);
 void qemu_clock_enable(QEMUClock *clock, int enabled);
 
-- 
1.7.4

  parent reply	other threads:[~2011-03-12 17:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-12 17:04 [Qemu-devel] [RFC PATCH 0/5] allow arbitrary scaling of timers Paolo Bonzini
2011-03-12 17:04 ` [Qemu-devel] [RFC PATCH 1/5] add more helper functions with explicit milli/nanosecond resolution Paolo Bonzini
2011-03-12 17:04 ` [Qemu-devel] [RFC PATCH 2/5] change all rt_clock references to use millisecond resolution accessors Paolo Bonzini
2011-03-12 17:04 ` [Qemu-devel] [RFC PATCH 3/5] change all other clock references to use nanosecond " Paolo Bonzini
2011-03-12 17:04 ` [Qemu-devel] [RFC PATCH 4/5] add a generic scaling mechanism for timers Paolo Bonzini
2011-03-12 17:04 ` Paolo Bonzini [this message]
2011-03-12 23:33 ` [Qemu-devel] [RFC PATCH 0/5] allow arbitrary scaling of timers Anthony Liguori
2011-03-14  7:14   ` Paolo Bonzini
2011-03-21 13:35     ` [Qemu-devel] [PULL] " Paolo Bonzini
2011-03-21 20:44       ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299949460-4387-6-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).