From: Richard Henderson <richard.henderson@linaro.org>
To: Helge Deller <deller@gmx.de>, qemu-devel@nongnu.org
Subject: Re: [PATCH][RFC] Add crash handler for qemu-linux-user
Date: Wed, 9 Aug 2023 18:27:17 -0700 [thread overview]
Message-ID: <129c90ab-14cc-04bb-493a-d4524b54c02f@linaro.org> (raw)
In-Reply-To: <ZNQcQxcL/22LmrVP@p100>
On 8/9/23 16:07, Helge Deller wrote:
> + /* did qemu source code crashed? */
> + if (unlikely(!h2g_valid(host_addr))) {
> + qemu_show_backtrace(info);
> + }
This won't do anything at all when reserved_va == 0,
i.e. 64-bit guest on 64-bit host, or any 32-bit host.
The idea of having a backtrace is nice, I suppose, we just need a better detector. Between
host_signal_pc() and adjust_signal_pc(), we should be able to determine if the access is
being done on behalf of the guest. If it isn't, it's a qemu bug.
r~
next prev parent reply other threads:[~2023-08-10 1:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 23:07 [PATCH][RFC] Add crash handler for qemu-linux-user Helge Deller
2023-08-10 1:27 ` Richard Henderson [this message]
2023-08-10 9:14 ` Peter Maydell
2023-08-17 10:58 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=129c90ab-14cc-04bb-493a-d4524b54c02f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=deller@gmx.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).