From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Djordje Todorovic <Djordje.Todorovic@htecgroup.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "qemu-riscv@nongnu.org" <qemu-riscv@nongnu.org>,
"cfu@mips.com" <cfu@mips.com>, "mst@redhat.com" <mst@redhat.com>,
"marcel.apfelbaum@gmail.com" <marcel.apfelbaum@gmail.com>,
"dbarboza@ventanamicro.com" <dbarboza@ventanamicro.com>
Subject: Re: [PATCH v5 00/11] riscv: Add support for MIPS P8700 CPU
Date: Tue, 15 Jul 2025 11:58:59 +0200 [thread overview]
Message-ID: <12b159a9-15b4-456f-a601-feda1176f3f8@linaro.org> (raw)
In-Reply-To: <20250703104925.112688-1-djordje.todorovic@htecgroup.com>
Hi,
On 3/7/25 12:49, Djordje Todorovic wrote:
> In v5 of this patch set I addressed two comments:
> - 02/11: Moved cpu_set_exception_base from target/riscv/translate.c
> to target/riscv/cpu.c, and added some NULL pointer checking so the
> code follows the convention
> - 08/11: Improved git commit message by explaining cmgcr and cpc,
> and introduced a macro for 0x100 offset used in those features
>
> The reset of the patches are the same.
>
> Djordje Todorovic (11):
> hw/intc: Allow gaps in hartids for aclint and aplic
> target/riscv: Add cpu_set_exception_base
> target/riscv: Add MIPS P8700 CPU
> target/riscv: Add MIPS P8700 CSRs
> target/riscv: Add mips.ccmov instruction
> target/riscv: Add mips.pref instruction
> target/riscv: Add Xmipslsp instructions
> hw/misc: Add RISC-V CMGCR and CPC device implementations
> hw/riscv: Add support for MIPS Boston-aia board model
> hw/pci: Allow explicit function numbers in pci
> riscv/boston-aia: Add an e1000e NIC in slot 0 func 1
At a glance, various new files miss their SPDX-License-Identifier,
which is now required.
Regards,
Phil.
prev parent reply other threads:[~2025-07-15 9:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 10:49 [PATCH v5 00/11] riscv: Add support for MIPS P8700 CPU Djordje Todorovic
2025-07-03 10:49 ` [PATCH v5 01/11] hw/intc: Allow gaps in hartids for aclint and aplic Djordje Todorovic
2025-07-03 10:49 ` [PATCH v5 02/11] target/riscv: Add cpu_set_exception_base Djordje Todorovic
2025-07-03 12:54 ` Daniel Henrique Barboza
2025-07-03 10:49 ` [PATCH v5 06/11] target/riscv: Add mips.pref instruction Djordje Todorovic
2025-07-03 10:49 ` [PATCH v5 05/11] target/riscv: Add mips.ccmov instruction Djordje Todorovic
2025-07-03 10:49 ` [PATCH v5 04/11] target/riscv: Add MIPS P8700 CSRs Djordje Todorovic
2025-07-03 10:49 ` [PATCH v5 03/11] target/riscv: Add MIPS P8700 CPU Djordje Todorovic
2025-07-03 10:49 ` [PATCH v5 08/11] hw/misc: Add RISC-V CMGCR and CPC device implementations Djordje Todorovic
2025-07-03 12:58 ` Daniel Henrique Barboza
2025-07-15 10:04 ` Philippe Mathieu-Daudé
2025-07-17 8:40 ` Djordje Todorovic
2025-07-03 10:49 ` [PATCH v5 07/11] target/riscv: Add Xmipslsp instructions Djordje Todorovic
2025-07-03 10:49 ` [PATCH v5 10/11] hw/pci: Allow explicit function numbers in pci Djordje Todorovic
2025-07-15 9:03 ` Djordje Todorovic
2025-07-03 10:49 ` [PATCH v5 11/11] riscv/boston-aia: Add an e1000e NIC in slot 0 func 1 Djordje Todorovic
2025-07-03 10:49 ` [PATCH v5 09/11] hw/riscv: Add support for MIPS Boston-aia board model Djordje Todorovic
2025-07-15 10:07 ` Philippe Mathieu-Daudé
2025-07-17 8:42 ` Djordje Todorovic
2025-07-15 9:58 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12b159a9-15b4-456f-a601-feda1176f3f8@linaro.org \
--to=philmd@linaro.org \
--cc=Djordje.Todorovic@htecgroup.com \
--cc=cfu@mips.com \
--cc=dbarboza@ventanamicro.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).