Re: [PULL 12/23] tests/functional/aspeed: Add to test vbootrom for AST2700

[Thomas Huth <thuth@redhat.com>]

On 05/05/2025 11.06, Cédric Le Goater wrote:
> From: Jamin Lin <jamin_lin@aspeedtech.com>
> 
> Add the AST2700 functional test to boot using the vbootrom image
> instead of manually loading boot components with -device loader.
> The boot ROM binary is now passed via the
> -bios option, using the image located in pc-bios/ast27x0_bootrom.bin.
...
> @@ -110,5 +127,14 @@ def test_aarch64_ast2700a1_evb_sdk_v09_06(self):
>           self.verify_openbmc_boot_and_login('ast2700-default')
>           self.do_ast2700_i2c_test()
>   
> +    def test_aarch64_ast2700a1_evb_sdk_vbootrom_v09_06(self):
> +        self.set_machine('ast2700a1-evb')
> +
> +        self.archive_extract(self.ASSET_SDK_V906_AST2700A1)
> +        self.start_ast2700_test_vbootrom('ast2700-default')
> +        self.verify_vbootrom_firmware_flow()
> +        self.verify_openbmc_boot_and_login('ast2700-default')
> +        self.do_ast2700_i2c_test()

  Hi,

just a question / idea: The ast2700 test is now one of the longest running 
aarch64 tests ... would it maybe be ok to drop (or disable by default) the 
test_aarch64_ast2700a1_evb_sdk_v09_06 test now that the vbootrom test has 
been added? Or do we really get a lot of additional test coverage (that we 
don't get by the a0 test yet) by booting Linux twice on the a1 machine here?

  Thanks,
   Thomas