From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
Joe Komlodi <joe.komlodi@xilinx.com>
Cc: qemu-arm <qemu-arm@nongnu.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH 0/1] target/arm: Check NaN mode before silencing NaN
Date: Mon, 28 Jun 2021 08:04:57 -0700 [thread overview]
Message-ID: <12d4c7de-1346-2aee-75f5-4db729b7f1c7@linaro.org> (raw)
In-Reply-To: <CAFEAcA_vxA12WMi6qdV2_wNiNAKZ4j6-FTKnwfphT7nGznJoYw@mail.gmail.com>
On 6/28/21 7:54 AM, Peter Maydell wrote:
> Richard, Alex: what is the assertion trying to achieve ? It doesn't
> seem entirely obvious to me that because we're in default-NaN mode
> (which is a property of the *output* of FPU insns) that we should
> blow up on calling float*_silence_nan() (which is typically an action
> performed on the *input* of FPU insns).
This was in response to e9e5534ff30.
My assumption in adding the assert is that it was probably a configuration error. If you
disagree, I suppose we can revert it, as it's not critical.
> If we do want to keep the assertion, somebody should audit the
> other frontends that use float*_silence_nan() (i386, m68k, s390x)
> to see if they also need updating.
Easily done. None of them ever set default_nan mode.
r~
next prev parent reply other threads:[~2021-06-28 15:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 23:02 [PATCH 0/1] target/arm: Check NaN mode before silencing NaN Joe Komlodi
2021-06-25 23:02 ` [PATCH 1/1] " Joe Komlodi
2021-06-26 2:18 ` Richard Henderson
2021-06-28 14:54 ` [PATCH 0/1] " Peter Maydell
2021-06-28 15:04 ` Richard Henderson [this message]
2021-06-29 9:38 ` Peter Maydell
2021-07-15 19:29 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12d4c7de-1346-2aee-75f5-4db729b7f1c7@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=joe.komlodi@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).