From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org
Subject: Re: [PATCH] target/arm: Fix syndrome for FGT traps on ERET
Date: Wed, 25 Oct 2023 16:41:45 -0700 [thread overview]
Message-ID: <12febade-6f85-484e-b416-09fce7eb38a5@linaro.org> (raw)
In-Reply-To: <20231024172438.2990945-1-peter.maydell@linaro.org>
On 10/24/23 10:24, Peter Maydell wrote:
> In commit 442c9d682c94fc2 when we converted the ERET, ERETAA, ERETAB
> instructions to decodetree, the conversion accidentally lost the
> correct setting of the syndrome register when taking a trap because
> of the FEAT_FGT HFGITR_EL1.ERET bit. Instead of reporting a correct
> full syndrome value with the EC and IL bits, we only reported the low
> two bits of the syndrome, because the call to syn_erettrap() got
> dropped.
>
> Fix the syndrome values for these traps by reinstating the
> syn_erettrap() calls.
>
> Fixes: 442c9d682c94fc2 ("target/arm: Convert ERET, ERETAA, ERETAB to decodetree")
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2023-10-25 23:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 17:24 [PATCH] target/arm: Fix syndrome for FGT traps on ERET Peter Maydell
2023-10-25 23:41 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12febade-6f85-484e-b416-09fce7eb38a5@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).