From: Max Reitz <mreitz@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Nir Soffer <nsoffer@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [PATCH v3 4/5] qcow2: Don't require aligned offsets in qcow2_co_copy_range_from()
Date: Tue, 21 Jan 2020 13:16:32 +0100 [thread overview]
Message-ID: <12ffae66-3ed3-bb69-e324-089522e32025@redhat.com> (raw)
In-Reply-To: <a4264aaee656910c84161a2965f7a501437379ca.1579374329.git.berto@igalia.com>
[-- Attachment #1.1: Type: text/plain, Size: 499 bytes --]
On 18.01.20 20:09, Alberto Garcia wrote:
> qemu-img's convert_co_copy_range() operates at the sector level and
> block_copy() operates at the cluster level so this condition is always
> true, but it is not necessary to restrict this here, so let's leave it
> to the driver implementation return an error if there is any.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> block/qcow2.c | 4 ----
> 1 file changed, 4 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-01-21 12:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-18 19:09 [PATCH v3 0/5] Misc BDRV_SECTOR_SIZE updates Alberto Garcia
2020-01-18 19:09 ` [PATCH v3 1/5] qcow2: Don't round the L1 table allocation up to the sector size Alberto Garcia
2020-01-18 19:09 ` [PATCH v3 2/5] qcow2: Tighten cluster_offset alignment assertions Alberto Garcia
2020-01-18 19:09 ` [PATCH v3 3/5] qcow2: Use bs->bl.request_alignment when updating an L1 entry Alberto Garcia
2020-01-21 12:15 ` Max Reitz
2020-01-18 19:09 ` [PATCH v3 4/5] qcow2: Don't require aligned offsets in qcow2_co_copy_range_from() Alberto Garcia
2020-01-21 12:16 ` Max Reitz [this message]
2020-01-18 19:09 ` [PATCH v3 5/5] qcow2: Use BDRV_SECTOR_SIZE instead of the hardcoded value Alberto Garcia
2020-01-21 12:19 ` Max Reitz
2020-01-21 12:20 ` [PATCH v3 0/5] Misc BDRV_SECTOR_SIZE updates Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12ffae66-3ed3-bb69-e324-089522e32025@redhat.com \
--to=mreitz@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=nsoffer@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).