From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35716 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PzF2u-0006My-C0 for qemu-devel@nongnu.org; Mon, 14 Mar 2011 17:11:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PzF2s-0007KZ-U9 for qemu-devel@nongnu.org; Mon, 14 Mar 2011 17:11:20 -0400 Received: from mga02.intel.com ([134.134.136.20]:33274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PzF2s-0007Jy-Lp for qemu-devel@nongnu.org; Mon, 14 Mar 2011 17:11:18 -0400 From: jordan.l.justen@intel.com Date: Mon, 14 Mar 2011 14:10:58 -0700 Message-Id: <1300137058-16576-1-git-send-email-jordan.l.justen@intel.com> Subject: [Qemu-devel] [PATCH] hw/pflash_cfi02: Fix lazy reset of ROMD mode List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Jordan Justen , jljusten@gmail.com From: Jordan Justen When checking pfl->rom_mode for when to lazily reenter ROMD mode, the value was check was the opposite of what it should have been. This prevent the part from returning to ROMD mode after a write was made to the CFI rom region. --- hw/pflash_cfi02.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pflash_cfi02.c b/hw/pflash_cfi02.c index 3594a36..a936cdb 100644 --- a/hw/pflash_cfi02.c +++ b/hw/pflash_cfi02.c @@ -112,7 +112,7 @@ static uint32_t pflash_read (pflash_t *pfl, target_phys_addr_t offset, DPRINTF("%s: offset " TARGET_FMT_plx "\n", __func__, offset); ret = -1; - if (pfl->rom_mode) { + if (!pfl->rom_mode) { /* Lazy reset of to ROMD mode */ if (pfl->wcycle == 0) pflash_register_memory(pfl, 1); -- 1.7.1