From: Alex Williamson <alex.williamson@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com, mcb30@ipxe.org
Subject: [Qemu-devel] Re: [PATCH] pc-bios: Use iPXE ROMs
Date: Tue, 15 Mar 2011 13:08:05 -0600 [thread overview]
Message-ID: <1300216085.3141.73.camel@x201> (raw)
In-Reply-To: <4D7FA366.30200@codemonkey.ws>
On Tue, 2011-03-15 at 12:35 -0500, Anthony Liguori wrote:
> On 03/15/2011 12:00 PM, Alex Williamson wrote:
> > Refresh PXE ROMs from the iPXE project (http://ipxe.org). This
> > includes moving eepro100 to use standard naming and including a
> > script to easily refresh PXE ROMs from either a local git tree
> > or the upstream project. We include the 'git describe' output
> > in the resulting product name, making it easy to identify and
> > reproduce.
> >
> > Signed-off-by: Alex Williamson<alex.williamson@redhat.com>
> > ---
> >
> > Anthony - I've skipped actually including the binary diffs here to
> > be friendly to the mailing list for review. You can reproduce them
> > with the included script. Note that pc-bios/gpxe-eepro100-80861209.rom
> > is moved to pc-bios/pxe-eepro100.bin when doing the commit. I'll be
> > happy to tar up the commit if you prefer. I've tested these ROMs using
> > ipxe v1.0.0-492-g23daab1.
> >
> > Makefile | 2 -
> > hw/eepro100.c | 2 -
> > pc-bios/README | 9 ++
> > pc-bios/gpxe-eepro100-80861209.rom | Bin
> > pc-bios/pxe-e1000.bin | Bin
> > pc-bios/pxe-eepro100.bin | Bin
> > pc-bios/pxe-ne2k_pci.bin | Bin
> > pc-bios/pxe-pcnet.bin | Bin
> > pc-bios/pxe-rtl8139.bin | Bin
> > pc-bios/pxe-virtio.bin | Bin
> > scripts/refresh-pxe-roms.sh | 138 ++++++++++++++++++++++++++++++++++++
> > 11 files changed, 146 insertions(+), 5 deletions(-)
> > delete mode 100644 pc-bios/gpxe-eepro100-80861209.rom
> > create mode 100644 pc-bios/pxe-eepro100.bin
> > create mode 100755 scripts/refresh-pxe-roms.sh
>
> We should probably just put ipxe in roms/ as a git submodule and have
> the make infrastructure (optionally) build each rom as appropriate.
>
> That way when we distribute releases, the ipxe code is part of the tarball.
That sounds fine to me. Do you want to add git://git.ipxe.org/ipxe.git
as a submodule in roms/ipxe and I'll follow-up with a patch to switch
over? I'm not sure how to deal with adding submodules via patches.
Thanks,
Alex
next prev parent reply other threads:[~2011-03-15 19:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 17:00 [Qemu-devel] [PATCH] pc-bios: Use iPXE ROMs Alex Williamson
2011-03-15 17:35 ` [Qemu-devel] " Anthony Liguori
2011-03-15 19:08 ` Alex Williamson [this message]
2011-03-15 22:24 ` [Qemu-devel] " Stefan Weil
2011-03-15 22:38 ` Alex Williamson
2011-03-16 18:48 ` Stefan Hajnoczi
2011-03-16 19:15 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300216085.3141.73.camel@x201 \
--to=alex.williamson@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=mcb30@ipxe.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).