From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36400 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PzZbI-0007yv-N5 for qemu-devel@nongnu.org; Tue, 15 Mar 2011 15:08:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PzZbH-0003pz-EE for qemu-devel@nongnu.org; Tue, 15 Mar 2011 15:08:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1025) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PzZbH-0003po-3L for qemu-devel@nongnu.org; Tue, 15 Mar 2011 15:08:11 -0400 From: Alex Williamson In-Reply-To: <4D7FA366.30200@codemonkey.ws> References: <20110315164902.11804.77678.stgit@s20.home> <4D7FA366.30200@codemonkey.ws> Content-Type: text/plain; charset="UTF-8" Date: Tue, 15 Mar 2011 13:08:05 -0600 Message-ID: <1300216085.3141.73.camel@x201> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] pc-bios: Use iPXE ROMs List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com, mcb30@ipxe.org On Tue, 2011-03-15 at 12:35 -0500, Anthony Liguori wrote: > On 03/15/2011 12:00 PM, Alex Williamson wrote: > > Refresh PXE ROMs from the iPXE project (http://ipxe.org). This > > includes moving eepro100 to use standard naming and including a > > script to easily refresh PXE ROMs from either a local git tree > > or the upstream project. We include the 'git describe' output > > in the resulting product name, making it easy to identify and > > reproduce. > > > > Signed-off-by: Alex Williamson > > --- > > > > Anthony - I've skipped actually including the binary diffs here to > > be friendly to the mailing list for review. You can reproduce them > > with the included script. Note that pc-bios/gpxe-eepro100-80861209.rom > > is moved to pc-bios/pxe-eepro100.bin when doing the commit. I'll be > > happy to tar up the commit if you prefer. I've tested these ROMs using > > ipxe v1.0.0-492-g23daab1. > > > > Makefile | 2 - > > hw/eepro100.c | 2 - > > pc-bios/README | 9 ++ > > pc-bios/gpxe-eepro100-80861209.rom | Bin > > pc-bios/pxe-e1000.bin | Bin > > pc-bios/pxe-eepro100.bin | Bin > > pc-bios/pxe-ne2k_pci.bin | Bin > > pc-bios/pxe-pcnet.bin | Bin > > pc-bios/pxe-rtl8139.bin | Bin > > pc-bios/pxe-virtio.bin | Bin > > scripts/refresh-pxe-roms.sh | 138 ++++++++++++++++++++++++++++++++++++ > > 11 files changed, 146 insertions(+), 5 deletions(-) > > delete mode 100644 pc-bios/gpxe-eepro100-80861209.rom > > create mode 100644 pc-bios/pxe-eepro100.bin > > create mode 100755 scripts/refresh-pxe-roms.sh > > We should probably just put ipxe in roms/ as a git submodule and have > the make infrastructure (optionally) build each rom as appropriate. > > That way when we distribute releases, the ipxe code is part of the tarball. That sounds fine to me. Do you want to add git://git.ipxe.org/ipxe.git as a submodule in roms/ipxe and I'll follow-up with a patch to switch over? I'm not sure how to deal with adding submodules via patches. Thanks, Alex