From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49795 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PzoEy-0004dQ-AA for qemu-devel@nongnu.org; Wed, 16 Mar 2011 06:46:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PzoEw-0002Ra-M0 for qemu-devel@nongnu.org; Wed, 16 Mar 2011 06:46:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39737) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PzoEw-0002RR-0g for qemu-devel@nongnu.org; Wed, 16 Mar 2011 06:46:06 -0400 From: Kevin Wolf Date: Wed, 16 Mar 2011 11:48:00 +0100 Message-Id: <1300272481-8744-9-git-send-email-kwolf@redhat.com> In-Reply-To: <1300272481-8744-1-git-send-email-kwolf@redhat.com> References: <1300272481-8744-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 8/9] hw/xen_disk: aio_inflight not released in handling ioreq when nr_segments==0 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Feiran Zheng In hw/xen_disk.c, async writing ioreq is leaked when ioreq->req.nr_segments==0, because `aio_inflight` flag is not released properly (skipped by misplaced "break"). Signed-off-by: Feiran Zheng Acked-by: Stefano Stabellini Signed-off-by: Kevin Wolf --- hw/xen_disk.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/xen_disk.c b/hw/xen_disk.c index ed9e5eb..445bf03 100644 --- a/hw/xen_disk.c +++ b/hw/xen_disk.c @@ -408,9 +408,9 @@ static int ioreq_runio_qemu_aio(struct ioreq *ioreq) break; case BLKIF_OP_WRITE: case BLKIF_OP_WRITE_BARRIER: - ioreq->aio_inflight++; if (!ioreq->req.nr_segments) break; + ioreq->aio_inflight++; bdrv_aio_writev(blkdev->bs, ioreq->start / BLOCK_SIZE, &ioreq->v, ioreq->v.size / BLOCK_SIZE, qemu_aio_complete, ioreq); -- 1.7.2.3