* [Qemu-devel] [PATCH] target-i386: Do not announce extended mwait features
@ 2011-03-16 14:25 Adam Lackorzynski
2011-03-16 17:19 ` Alexander Graf
0 siblings, 1 reply; 2+ messages in thread
From: Adam Lackorzynski @ 2011-03-16 14:25 UTC (permalink / raw)
To: qemu-devel
CPUID claims that extended monitor/mwait features are available but the
mwait helper instantly raises a GPF if they are used. Thus do not announce
that the extension are available.
Signed-off-by: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
---
target-i386/cpuid.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c
index 5382a28..28275a6 100644
--- a/target-i386/cpuid.c
+++ b/target-i386/cpuid.c
@@ -1104,7 +1104,7 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count,
/* mwait info: needed for Core compatibility */
*eax = 0; /* Smallest monitor-line size in bytes */
*ebx = 0; /* Largest monitor-line size in bytes */
- *ecx = CPUID_MWAIT_EMX | CPUID_MWAIT_IBE;
+ *ecx = 0; /* Supported extensions */
*edx = 0;
break;
case 6:
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] target-i386: Do not announce extended mwait features
2011-03-16 14:25 [Qemu-devel] [PATCH] target-i386: Do not announce extended mwait features Adam Lackorzynski
@ 2011-03-16 17:19 ` Alexander Graf
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Graf @ 2011-03-16 17:19 UTC (permalink / raw)
To: Adam Lackorzynski; +Cc: qemu-devel
On 03/16/2011 03:25 PM, Adam Lackorzynski wrote:
> CPUID claims that extended monitor/mwait features are available but the
> mwait helper instantly raises a GPF if they are used. Thus do not announce
> that the extension are available.
Would be better to just implement mwait, no?
Alex
> Signed-off-by: Adam Lackorzynski<adam@os.inf.tu-dresden.de>
> ---
> target-i386/cpuid.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c
> index 5382a28..28275a6 100644
> --- a/target-i386/cpuid.c
> +++ b/target-i386/cpuid.c
> @@ -1104,7 +1104,7 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count,
> /* mwait info: needed for Core compatibility */
> *eax = 0; /* Smallest monitor-line size in bytes */
> *ebx = 0; /* Largest monitor-line size in bytes */
> - *ecx = CPUID_MWAIT_EMX | CPUID_MWAIT_IBE;
> + *ecx = 0; /* Supported extensions */
> *edx = 0;
> break;
> case 6:
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-16 17:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-16 14:25 [Qemu-devel] [PATCH] target-i386: Do not announce extended mwait features Adam Lackorzynski
2011-03-16 17:19 ` Alexander Graf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).