From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=47756 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PzwBx-0001fr-Aa
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 15:15:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1PzwBw-0000Az-2L
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 15:15:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44436)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1PzwBv-0000Ao-OC
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 15:15:32 -0400
Subject: Re: [Qemu-devel] [PATCH] pc-bios: Use iPXE ROMs
From: Alex Williamson <alex.williamson@redhat.com>
In-Reply-To: <AANLkTin=1GmYkDKSAZ+8B+gmcnrRfgik7Z2odtOWxpuJ@mail.gmail.com>
References: <20110315164902.11804.77678.stgit@s20.home>
	<AANLkTin=1GmYkDKSAZ+8B+gmcnrRfgik7Z2odtOWxpuJ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Date: Wed, 16 Mar 2011 13:15:21 -0600
Message-ID: <1300302921.3282.1.camel@x201>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com, mcb30@ipxe.org

On Wed, 2011-03-16 at 18:48 +0000, Stefan Hajnoczi wrote:
> On Tue, Mar 15, 2011 at 5:00 PM, Alex Williamson
> <alex.williamson@redhat.com> wrote:
> > diff --git a/scripts/refresh-pxe-roms.sh b/scripts/refresh-pxe-roms.sh
> 
> Please enclose variable expansions in double-quotes so paths with
> spaces in them work.  For example:
> cp $BUILD_DIR/$LOCAL_CONFIG $SAVED_CONFIG
> 
> This will not do what you want if BUILD_DIR, LOCAL_CONFIG, or
> SAVED_CONFIG have spaces.  Instead use:
> cp "$BUILD_DIR/$LOCAL_CONFIG" "$SAVED_CONFIG"

Thanks, I'll update.

> > +function make_all ()
> > +{
> > +       cd $BUILD_DIR/src
> > +
> > +       BUILD_LOG=$(mktemp)
> > +
> > +       echo Building...
> > +
> > +       make $1 > $BUILD_LOG 2>&1
> > +
> > +       if [ $? -ne 0 ]; then
> > +               echo Build failed
> > +               tail --lines=100 $BUILD_LOG
> > +               rm $BUILD_LOG
> > +               cleanup
> > +               exit 1
> > +       fi
> > +       rm $BUILD_LOG
> > +
> > +       cd $QEMU_DIR
> > +}
> 
> What is the purpose of this function?  If you build one of the ROMs
> all of iPXE gets compiled.  I'm not sure why we need to make all and
> then make specific ROMs.

I just figured it'd be easier to debug if I separated out the main build
from each rom.  Maybe it just confuses things instead.  Thanks,

Alex