From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34259 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PzxSg-0001Eb-Ay
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 16:37:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1PzxSW-0001K8-Pp
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 16:36:46 -0400
Received: from gate.crashing.org ([63.228.1.57]:56328)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1PzxSW-0001Jj-Il
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 16:36:44 -0400
Subject: Re: [Qemu-devel] Re: [PATCH 21/26] Implement TCE translation for
	sPAPR VIO
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
In-Reply-To: <4D811C02.2000109@codemonkey.ws>
References: <1300251423-6715-1-git-send-email-david@gibson.dropbear.id.au>
	<1300251423-6715-22-git-send-email-david@gibson.dropbear.id.au>
	<4D80DF6A.8040107@suse.de> <1300305919.22236.1175.camel@pasglop>
	<4D811C02.2000109@codemonkey.ws>
Content-Type: text/plain; charset="UTF-8"
Date: Thu, 17 Mar 2011 07:36:31 +1100
Message-ID: <1300307791.22236.1181.camel@pasglop>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: David Gibson <david@gibson.dropbear.id.au>, paulus@samba.org, Alexander Graf <agraf@suse.de>, anton@samba.org, qemu-devel@nongnu.org

On Wed, 2011-03-16 at 15:22 -0500, Anthony Liguori wrote:
> 
> But BTW, if you're already being evil and using alloca, it's a whole
> lot 
> nicer to just do:
> 
> uint8_t zeros[size];

Right. I haven't written that bit of the code so I'll let David fix it
but it does indeed look nicer. Eventually, we -could- I suppose make
some of these faster since all we really need is poke at the guest
memory and I'm sure we can do it directly a way or another :-)

Cheers,
Ben.