qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "M. Mohan Kumar" <mohan@in.ibm.com>
To: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@gmail.com>
Subject: [Qemu-devel] [V9 PATCH 00/13] virtio-9p: Use chroot to safely access files in passthrough security model
Date: Fri, 18 Mar 2011 08:57:48 +0530	[thread overview]
Message-ID: <1300418881-20972-1-git-send-email-mohan@in.ibm.com> (raw)

In passthrough security model, following symbolic links in the server
side could result in TOCTTOU vulnerabilities.

This patchset resolves this issue by creating a dedicated process which
chroots into the share path and all file object access is done in the
chroot environment.

This patchset implements chroot enviroment, provides necessary functions
that can be used by the passthrough function calls.

Changes from version V8:
* Make chmod and chown also operate under chroot process
* Check for invalid path requests, minor cleanups

Changes from version V7:
* Add two chroot methods remove and rename
* Minor cleanups like consolidating functions

Changes from version V6:
* Send only fd/errno in socket operations instead of FdInfo structure
* Minor cleanups

Changes from version V5:
* Return errno on failure instead of setting errno
* Minor cleanups like updated comments, enable CONFIG_THREAD if
  CONFIG_VIRTFS is enabled

Changes from version V4:
* Avoid using malloc/free inside chroot process
* Seperate chroot server and client functions

Changes from version V3
* Return EIO incase of socket read/write fail instead of exiting
* Changed data types as suggested by Blue Swirl
* Chroot process reports error through qemu process

Changes from version V2
* Treat socket IO errors as fatal, ie qemu will exit
* Split patchset based on chroot side (server) and qemu side(client)
  functionalities

M. Mohan Kumar (13):
  Implement qemu_read_full
  virtio-9p: Enable CONFIG_THREAD if CONFIG_VIRTFS is enabled
  virtio-9p: Provide chroot worker side interfaces
  virtio-9p: Add qemu side interfaces for chroot environment
  virtio-9p: Add support to open a file in chroot environment
  virtio-9p: Create support in chroot environment
  virtio-9p: Support for creating special files
  virtio-9p: Add support for removing file or directory
  virtio-9p: Add support to rename
  virtio-9p: Move file post creation changes to none security model
  virtio-9p: Add support for chmod
  virtio-9p: Add support for chown
  virtio-9p: Chroot environment for other functions

 Makefile.objs                     |    1 +
 configure                         |    1 +
 hw/9pfs/virtio-9p-chroot-worker.c |  342 +++++++++++++++++++++++++++++++++++++
 hw/9pfs/virtio-9p-chroot.c        |  105 +++++++++++
 hw/9pfs/virtio-9p-chroot.h        |   47 +++++
 hw/9pfs/virtio-9p-local.c         |  332 +++++++++++++++++++++++++++---------
 hw/9pfs/virtio-9p.c               |   24 +++
 hw/file-op-9p.h                   |    3 +
 osdep.c                           |   32 ++++
 qemu-common.h                     |    2 +
 10 files changed, 811 insertions(+), 78 deletions(-)
 create mode 100644 hw/9pfs/virtio-9p-chroot-worker.c
 create mode 100644 hw/9pfs/virtio-9p-chroot.c
 create mode 100644 hw/9pfs/virtio-9p-chroot.h

-- 
1.7.3.4

             reply	other threads:[~2011-03-18  3:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-18  3:27 M. Mohan Kumar [this message]
2011-03-18  3:27 ` [Qemu-devel] [V9 PATCH 01/13] Implement qemu_read_full M. Mohan Kumar
2011-03-18  3:27 ` [Qemu-devel] [V9 PATCH 02/13] virtio-9p: Enable CONFIG_THREAD if CONFIG_VIRTFS is enabled M. Mohan Kumar
2011-03-18  3:27 ` [Qemu-devel] [V9 PATCH 03/13] virtio-9p: Provide chroot worker side interfaces M. Mohan Kumar
2011-03-18  3:27 ` [Qemu-devel] [V9 PATCH 04/13] virtio-9p: Add qemu side interfaces for chroot environment M. Mohan Kumar
2011-03-18  3:27 ` [Qemu-devel] [V9 PATCH 05/13] virtio-9p: Add support to open a file in " M. Mohan Kumar
2011-03-18  3:27 ` [Qemu-devel] [V9 PATCH 06/13] virtio-9p: Create support " M. Mohan Kumar
2011-03-18  3:27 ` [Qemu-devel] [V9 PATCH 07/13] virtio-9p: Support for creating special files M. Mohan Kumar
2011-03-18  3:27 ` [Qemu-devel] [V9 PATCH 08/13] virtio-9p: Add support for removing file or directory M. Mohan Kumar
2011-03-18  3:27 ` [Qemu-devel] [V9 PATCH 09/13] virtio-9p: Add support to rename M. Mohan Kumar
2011-03-18  3:27 ` [Qemu-devel] [V9 PATCH 10/13] virtio-9p: Move file post creation changes to none security model M. Mohan Kumar
2011-03-18  3:27 ` [Qemu-devel] [V9 PATCH 11/13] virtio-9p: Add support for chmod M. Mohan Kumar
2011-03-18  3:28 ` [Qemu-devel] [V9 PATCH 12/13] virtio-9p: Add support for chown M. Mohan Kumar
2011-03-18  3:28 ` [Qemu-devel] [V9 PATCH 13/13] virtio-9p: Chroot environment for other functions M. Mohan Kumar
2011-03-28 21:06   ` [Qemu-devel] " Stefan Hajnoczi
2011-03-29  5:55     ` M. Mohan Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300418881-20972-1-git-send-email-mohan@in.ibm.com \
    --to=mohan@in.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).