qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "M. Mohan Kumar" <mohan@in.ibm.com>
To: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@gmail.com>
Subject: [Qemu-devel] [V9 PATCH 11/13] virtio-9p: Add support for chmod
Date: Fri, 18 Mar 2011 08:57:59 +0530	[thread overview]
Message-ID: <1300418881-20972-12-git-send-email-mohan@in.ibm.com> (raw)
In-Reply-To: <1300418881-20972-1-git-send-email-mohan@in.ibm.com>

Add support to do chmod operation in chroot process.

Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
---
 hw/9pfs/virtio-9p-chroot-worker.c |   18 ++++++++++++++++++
 hw/9pfs/virtio-9p-chroot.h        |    1 +
 hw/9pfs/virtio-9p-local.c         |    5 +++--
 3 files changed, 22 insertions(+), 2 deletions(-)

diff --git a/hw/9pfs/virtio-9p-chroot-worker.c b/hw/9pfs/virtio-9p-chroot-worker.c
index 353aeed..dc92ea2 100644
--- a/hw/9pfs/virtio-9p-chroot-worker.c
+++ b/hw/9pfs/virtio-9p-chroot-worker.c
@@ -190,6 +190,21 @@ static int chroot_do_rename(V9fsFileObjectRequest *request)
     return 0;
 }
 
+/*
+ * Change permissions of a file object
+ * Returns 0 on success and -errno on failure
+ */
+static int chroot_do_chmod(V9fsFileObjectRequest *request)
+{
+    int retval;
+
+    retval = chmod(request->path.path, request->data.mode);
+    if (retval < 0) {
+        return -errno;
+    }
+    return 0;
+}
+
 static void chroot_daemonize(int chroot_sock)
 {
     sigset_t sigset;
@@ -297,6 +312,9 @@ int v9fs_chroot(FsContext *fs_ctx)
         case T_RENAME:
             retval = chroot_do_rename(&request);
             break;
+        case T_CHMOD:
+            retval = chroot_do_chmod(&request);
+            break;
         default:
             retval = -1;
             break;
diff --git a/hw/9pfs/virtio-9p-chroot.h b/hw/9pfs/virtio-9p-chroot.h
index e8251b4..d2c0e5f 100644
--- a/hw/9pfs/virtio-9p-chroot.h
+++ b/hw/9pfs/virtio-9p-chroot.h
@@ -10,6 +10,7 @@
 #define T_LINK      6
 #define T_REMOVE    7
 #define T_RENAME    8
+#define T_CHMOD     9
 
 union MsgControl {
     struct cmsghdr cmsg;
diff --git a/hw/9pfs/virtio-9p-local.c b/hw/9pfs/virtio-9p-local.c
index 65622de..7f7b648 100644
--- a/hw/9pfs/virtio-9p-local.c
+++ b/hw/9pfs/virtio-9p-local.c
@@ -267,8 +267,9 @@ static int local_chmod(FsContext *fs_ctx, const char *path, FsCred *credp)
 {
     if (fs_ctx->fs_sm == SM_MAPPED) {
         return local_set_xattr(rpath(fs_ctx, path), credp);
-    } else if ((fs_ctx->fs_sm == SM_PASSTHROUGH) ||
-               (fs_ctx->fs_sm == SM_NONE)) {
+    } else if (fs_ctx->fs_sm == SM_PASSTHROUGH) {
+        return passthrough_request(fs_ctx, NULL, path, 0, credp, T_CHMOD);
+    } else if (fs_ctx->fs_sm == SM_NONE) {
         return chmod(rpath(fs_ctx, path), credp->fc_mode);
     }
     return -1;
-- 
1.7.3.4

  parent reply	other threads:[~2011-03-18  3:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-18  3:27 [Qemu-devel] [V9 PATCH 00/13] virtio-9p: Use chroot to safely access files in passthrough security model M. Mohan Kumar
2011-03-18  3:27 ` [Qemu-devel] [V9 PATCH 01/13] Implement qemu_read_full M. Mohan Kumar
2011-03-18  3:27 ` [Qemu-devel] [V9 PATCH 02/13] virtio-9p: Enable CONFIG_THREAD if CONFIG_VIRTFS is enabled M. Mohan Kumar
2011-03-18  3:27 ` [Qemu-devel] [V9 PATCH 03/13] virtio-9p: Provide chroot worker side interfaces M. Mohan Kumar
2011-03-18  3:27 ` [Qemu-devel] [V9 PATCH 04/13] virtio-9p: Add qemu side interfaces for chroot environment M. Mohan Kumar
2011-03-18  3:27 ` [Qemu-devel] [V9 PATCH 05/13] virtio-9p: Add support to open a file in " M. Mohan Kumar
2011-03-18  3:27 ` [Qemu-devel] [V9 PATCH 06/13] virtio-9p: Create support " M. Mohan Kumar
2011-03-18  3:27 ` [Qemu-devel] [V9 PATCH 07/13] virtio-9p: Support for creating special files M. Mohan Kumar
2011-03-18  3:27 ` [Qemu-devel] [V9 PATCH 08/13] virtio-9p: Add support for removing file or directory M. Mohan Kumar
2011-03-18  3:27 ` [Qemu-devel] [V9 PATCH 09/13] virtio-9p: Add support to rename M. Mohan Kumar
2011-03-18  3:27 ` [Qemu-devel] [V9 PATCH 10/13] virtio-9p: Move file post creation changes to none security model M. Mohan Kumar
2011-03-18  3:27 ` M. Mohan Kumar [this message]
2011-03-18  3:28 ` [Qemu-devel] [V9 PATCH 12/13] virtio-9p: Add support for chown M. Mohan Kumar
2011-03-18  3:28 ` [Qemu-devel] [V9 PATCH 13/13] virtio-9p: Chroot environment for other functions M. Mohan Kumar
2011-03-28 21:06   ` [Qemu-devel] " Stefan Hajnoczi
2011-03-29  5:55     ` M. Mohan Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300418881-20972-12-git-send-email-mohan@in.ibm.com \
    --to=mohan@in.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).