qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Juan Quintela <quintela@redhat.com>
Subject: [Qemu-devel] [PATCH 04/11] sb16: fix migration quirk
Date: Tue, 22 Mar 2011 19:16:09 -0500	[thread overview]
Message-ID: <1300839376-22520-5-git-send-email-aliguori@us.ibm.com> (raw)
In-Reply-To: <1300839376-22520-1-git-send-email-aliguori@us.ibm.com>

We seem to migrate the same field twice.  It's been this way since Fabrice
committed the original file.  Since semantically, we basically ignore the first
value, make this an unused entry.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---
 hw/sb16.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/hw/sb16.c b/hw/sb16.c
index c98546a..1c30e4c 100644
--- a/hw/sb16.c
+++ b/hw/sb16.c
@@ -77,6 +77,7 @@ typedef struct SB16State {
 
     int v2x6;
 
+    uint8_t csp_param_dummy;
     uint8_t csp_param;
     uint8_t csp_value;
     uint8_t csp_mode;
@@ -1313,7 +1314,7 @@ static const VMStateDescription vmstate_sb16 = {
         VMSTATE_INT32(can_write, SB16State),
         VMSTATE_INT32(v2x6, SB16State),
 
-        VMSTATE_UINT8(csp_param, SB16State),
+        VMSTATE_UINT8(csp_param_dummy, SB16State),
         VMSTATE_UINT8(csp_value, SB16State),
         VMSTATE_UINT8(csp_mode, SB16State),
         VMSTATE_UINT8(csp_param, SB16State),
-- 
1.7.0.4

  parent reply	other threads:[~2011-03-23  0:16 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-23  0:16 [Qemu-devel] [PATCH 00/11] Add live migration unit tests Anthony Liguori
2011-03-23  0:16 ` [Qemu-devel] [PATCH 01/11] Add hard build dependency on glib Anthony Liguori
2011-03-23  8:13   ` Stefan Hajnoczi
2011-03-23  8:19     ` Roy Tam
2011-03-23  8:41       ` Stefan Hajnoczi
2011-03-23  8:58         ` Roy Tam
2011-03-23  9:19           ` [Qemu-devel] " Paolo Bonzini
2011-03-23  9:22           ` [Qemu-devel] " Stefan Hajnoczi
2011-03-23  0:16 ` [Qemu-devel] [PATCH 02/11] vmstate: register all VMStateDescriptions Anthony Liguori
2011-03-23  9:00   ` Alon Levy
2011-03-23 12:30   ` Peter Maydell
2011-03-23 12:37     ` Anthony Liguori
2011-03-23  0:16 ` [Qemu-devel] [PATCH 03/11] vmstate: for vmstate types that reuse the same field, make sure name is unique Anthony Liguori
2011-03-23  2:29   ` Anthony Liguori
2011-03-23  0:16 ` Anthony Liguori [this message]
2011-03-23  9:51   ` [Qemu-devel] Re: [PATCH 04/11] sb16: fix migration quirk Juan Quintela
2011-03-23 12:16     ` Anthony Liguori
2011-03-23  0:16 ` [Qemu-devel] [PATCH 05/11] vga-isa: fix migration by breaking it Anthony Liguori
2011-03-23  9:54   ` [Qemu-devel] " Juan Quintela
2011-03-23  0:16 ` [Qemu-devel] [PATCH 06/11] fdc: fix migration of non-ISA fdc devices Anthony Liguori
2011-03-23  0:16 ` [Qemu-devel] [PATCH 07/11] eeprom93xx: Use the new hack macro to avoid duplicate field names Anthony Liguori
2011-03-23  9:58   ` [Qemu-devel] " Juan Quintela
2011-03-23 12:34     ` Anthony Liguori
2011-03-23 14:14       ` Juan Quintela
2011-03-23 14:33         ` Anthony Liguori
2011-03-23  0:16 ` [Qemu-devel] [PATCH 08/11] fw_cfg: make sure all VMState fields are unique Anthony Liguori
2011-03-23  0:16 ` [Qemu-devel] [PATCH 09/11] pckbd: make non-ISA pckbd use a unique name Anthony Liguori
2011-03-23  0:16 ` [Qemu-devel] [PATCH 10/11] vl: add a new -vmstate-dump option to write a VMState JSON schema Anthony Liguori
2011-03-23  0:16 ` [Qemu-devel] [PATCH 11/11] test-vmstate: add test case to verify we don't change VMState Anthony Liguori
2011-03-23  2:31   ` Anthony Liguori
2011-03-23  8:37   ` Stefan Hajnoczi
2011-03-23 10:22   ` Peter Maydell
2011-03-23 12:42     ` Anthony Liguori
2011-03-23 14:17       ` [Qemu-devel] " Juan Quintela
2011-03-23 14:52         ` Anthony Liguori
2011-03-23 15:00           ` Peter Maydell
2011-03-23 15:06             ` Jan Kiszka
2011-03-23 16:27             ` Anthony Liguori
2011-03-23 16:36               ` Jan Kiszka
2011-03-23 18:42                 ` Anthony Liguori
2011-03-23 16:45               ` Peter Maydell
2011-03-23 17:01                 ` Anthony Liguori
2011-03-23 15:26           ` Juan Quintela
2011-03-23 16:14             ` Anthony Liguori
2011-03-23 16:44               ` Juan Quintela
2011-03-23 14:19     ` Juan Quintela
2011-03-23 14:36       ` Peter Maydell
2011-03-23 15:13         ` Juan Quintela
2011-03-23 15:24           ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300839376-22520-5-git-send-email-aliguori@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).