From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=51458 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q3ZlS-00039g-Uz for qemu-devel@nongnu.org; Sat, 26 Mar 2011 16:07:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q3ZlR-0006Py-Pj for qemu-devel@nongnu.org; Sat, 26 Mar 2011 16:07:14 -0400 Received: from moutng.kundenserver.de ([212.227.17.10]:54003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q3ZlR-0006Np-EG for qemu-devel@nongnu.org; Sat, 26 Mar 2011 16:07:13 -0400 From: Stefan Weil Date: Sat, 26 Mar 2011 21:06:55 +0100 Message-Id: <1301170017-12368-1-git-send-email-weil@mail.berlios.de> Subject: [Qemu-devel] [PATCH 1/3] cpu-common: Modify cpu_physical_memory_read and cpu_physical_memory_write List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: QEMU Developers Cc: Blue Swirl A lot of calls don't operate on bytes but on words or on structured data. So instead of a pointer to uint8_t, a void pointer is the better choice. This allows removing many type casts. (Some very early implementations of memcpy used char pointers which were replaced by void pointers for the same reason). Cc: Blue Swirl Signed-off-by: Stefan Weil --- cpu-common.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cpu-common.h b/cpu-common.h index ef4e8da..f44a2b0 100644 --- a/cpu-common.h +++ b/cpu-common.h @@ -68,12 +68,12 @@ void cpu_unregister_io_memory(int table_address); void cpu_physical_memory_rw(target_phys_addr_t addr, uint8_t *buf, int len, int is_write); static inline void cpu_physical_memory_read(target_phys_addr_t addr, - uint8_t *buf, int len) + void *buf, int len) { cpu_physical_memory_rw(addr, buf, len, 0); } static inline void cpu_physical_memory_write(target_phys_addr_t addr, - const uint8_t *buf, int len) + const void *buf, int len) { cpu_physical_memory_rw(addr, (uint8_t *)buf, len, 1); } -- 1.7.2.5