From: Alexander Graf <agraf@suse.de>
To: qemu-devel@nongnu.org
Cc: Amit Shah <amit.shah@redhat.com>,
peter.maydell@linaro.org, aurelien@aurel32.net, rth@twiddle.net
Subject: [Qemu-devel] [PATCH 04/19] s390x: fix s390-virtio-serial
Date: Tue, 29 Mar 2011 15:29:31 +0200 [thread overview]
Message-ID: <1301405386-25738-5-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1301405386-25738-1-git-send-email-agraf@suse.de>
Commit 6b331efb733a0f913ddc0b7762a1307dec304061 broke the s390 proxy version
of virtio-serial by only taking its PCI brother into account.
So let's adjust s390-virtio-serial the same way as its PCI counterpart, making
it compile and work again.
Signed-off-by: Alexander Graf <agraf@suse.de>
CC: Amit Shah <amit.shah@redhat.com>
---
hw/s390-virtio-bus.c | 6 +++---
hw/s390-virtio-bus.h | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/s390-virtio-bus.c b/hw/s390-virtio-bus.c
index d44eff2..58af164 100644
--- a/hw/s390-virtio-bus.c
+++ b/hw/s390-virtio-bus.c
@@ -139,7 +139,7 @@ static int s390_virtio_serial_init(VirtIOS390Device *dev)
bus = DO_UPCAST(VirtIOS390Bus, bus, dev->qdev.parent_bus);
- vdev = virtio_serial_init((DeviceState *)dev, dev->max_virtserial_ports);
+ vdev = virtio_serial_init((DeviceState *)dev, &dev->serial);
if (!vdev) {
return -1;
}
@@ -355,8 +355,8 @@ static VirtIOS390DeviceInfo s390_virtio_serial = {
.qdev.alias = "virtio-serial",
.qdev.size = sizeof(VirtIOS390Device),
.qdev.props = (Property[]) {
- DEFINE_PROP_UINT32("max_ports", VirtIOS390Device, max_virtserial_ports,
- 31),
+ DEFINE_PROP_UINT32("max_ports", VirtIOS390Device,
+ serial.max_virtserial_ports, 31),
DEFINE_PROP_END_OF_LIST(),
},
};
diff --git a/hw/s390-virtio-bus.h b/hw/s390-virtio-bus.h
index 33379a3..edf6d04 100644
--- a/hw/s390-virtio-bus.h
+++ b/hw/s390-virtio-bus.h
@@ -18,6 +18,7 @@
*/
#include "virtio-net.h"
+#include "virtio-serial.h"
#define VIRTIO_DEV_OFFS_TYPE 0 /* 8 bits */
#define VIRTIO_DEV_OFFS_NUM_VQ 1 /* 8 bits */
@@ -43,8 +44,7 @@ typedef struct VirtIOS390Device {
BlockConf block;
NICConf nic;
uint32_t host_features;
- /* Max. number of ports we can have for a the virtio-serial device */
- uint32_t max_virtserial_ports;
+ virtio_serial_conf serial;
virtio_net_conf net;
} VirtIOS390Device;
--
1.6.0.2
next prev parent reply other threads:[~2011-03-29 13:29 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 13:29 [Qemu-devel] [PATCH 00/19] s390x emulation support Alexander Graf
2011-03-29 13:29 ` [Qemu-devel] [PATCH 01/19] Only build ivshmem when CONFIG_PCI && CONFIG_KVM Alexander Graf
2011-03-29 13:29 ` [Qemu-devel] [PATCH 02/19] virtio: use generic name when possible Alexander Graf
2011-03-29 13:29 ` [Qemu-devel] [PATCH 03/19] s390x: fix KVM target Alexander Graf
2011-03-29 13:29 ` Alexander Graf [this message]
2011-03-29 14:17 ` [Qemu-devel] Re: [PATCH 04/19] s390x: fix s390-virtio-serial Amit Shah
2011-03-29 13:29 ` [Qemu-devel] [PATCH 05/19] s390x: Enable disassembler for s390x Alexander Graf
2011-03-29 13:29 ` [Qemu-devel] [PATCH 06/19] s390x: Enable nptl " Alexander Graf
2011-03-29 13:29 ` [Qemu-devel] [PATCH 07/19] s390x: enable CPU_QuadU Alexander Graf
2011-03-29 13:29 ` [Qemu-devel] [PATCH 08/19] s390x: s390x-linux-user support Alexander Graf
2011-03-29 13:29 ` [Qemu-devel] [PATCH 09/19] linux-user: define a couple of syscalls for non-uid16 targets Alexander Graf
2011-03-29 13:29 ` [Qemu-devel] [PATCH 10/19] s390x: Enable s390x-softmmu target Alexander Graf
2011-03-29 13:29 ` [Qemu-devel] [PATCH 11/19] s390x: Dispatch interrupts to KVM or the real CPU Alexander Graf
2011-03-29 13:29 ` [Qemu-devel] [PATCH 12/19] s390x: Adjust GDB stub Alexander Graf
2011-03-29 13:29 ` [Qemu-devel] [PATCH 13/19] s390x: virtio machine storage keys Alexander Graf
2011-03-29 13:29 ` [Qemu-devel] [PATCH 14/19] s390x: Prepare cpu.h for emulation Alexander Graf
2011-03-29 13:29 ` [Qemu-devel] [PATCH 15/19] s390x: helper functions for system emulation Alexander Graf
2011-03-29 13:29 ` [Qemu-devel] [PATCH 16/19] s390x: Implement opcode helpers Alexander Graf
2011-03-29 16:13 ` [Qemu-devel] " Richard Henderson
2011-03-29 16:25 ` Alexander Graf
2011-03-29 13:29 ` [Qemu-devel] [PATCH 17/19] s390x: Adjust internal kvm code Alexander Graf
2011-03-29 13:29 ` [Qemu-devel] [PATCH 18/19] s390x: translate engine for s390x CPU Alexander Graf
2011-03-29 13:29 ` [Qemu-devel] [PATCH 19/19] s390x: build s390x by default Alexander Graf
2011-03-30 10:23 ` [Qemu-devel] Re: [PATCH 00/19] s390x emulation support Peter Maydell
2011-03-30 10:46 ` Alexander Graf
2011-03-30 15:14 ` Peter Maydell
2011-04-03 22:37 ` [Qemu-devel] " Aurelien Jarno
2011-04-03 22:43 ` Alexander Graf
2011-04-04 9:29 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301405386-25738-5-git-send-email-agraf@suse.de \
--to=agraf@suse.de \
--cc=amit.shah@redhat.com \
--cc=aurelien@aurel32.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).