From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=49951 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q51pH-0003of-Tf
	for qemu-devel@nongnu.org; Wed, 30 Mar 2011 16:17:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <levinsasha928@gmail.com>) id 1Q51pG-0003kQ-Sv
	for qemu-devel@nongnu.org; Wed, 30 Mar 2011 16:17:11 -0400
Received: from mail-wy0-f173.google.com ([74.125.82.173]:45307)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <levinsasha928@gmail.com>) id 1Q51pG-0003kE-Mc
	for qemu-devel@nongnu.org; Wed, 30 Mar 2011 16:17:10 -0400
Received: by wyb42 with SMTP id 42so1580208wyb.4
	for <qemu-devel@nongnu.org>; Wed, 30 Mar 2011 13:17:09 -0700 (PDT)
Subject: Re: [Qemu-devel] [PATCH] Don't limit node count by smp count
From: Sasha Levin <levinsasha928@gmail.com>
In-Reply-To: <4D938459.4070409@codemonkey.ws>
References: <1301512475.2976.3.camel@sasha> <4D938459.4070409@codemonkey.ws>
Content-Type: text/plain; charset="us-ascii"
Date: Wed, 30 Mar 2011 22:17:04 +0200
Message-ID: <1301516224.2976.6.camel@sasha>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

On Wed, 2011-03-30 at 14:28 -0500, Anthony Liguori wrote:
> On 03/30/2011 02:14 PM, Sasha Levin wrote:
> > It is possible to create CPU-less NUMA nodes, node amount shouldn't be
> > limited by amount of CPUs.
> 
> But does this actually work in the code today and does it work with any 
> guests?
> 

I've tested it on an Ubuntu desktop as a guest and it worked
fine, /sys/devices/system/node/has_cpu was as expected.

> Regards,
> 
> Anthony Liguori
> 
> > Signed-off-by: Sasha Levin<levinsasha928@gmail.com>
> > ---
> >   vl.c |    4 ++--
> >   1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/vl.c b/vl.c
> > index 8bcf2ae..8cc1aa8 100644
> > --- a/vl.c
> > +++ b/vl.c
> > @@ -3002,8 +3002,8 @@ int main(int argc, char **argv, char **envp)
> >       if (nb_numa_nodes>  0) {
> >           int i;
> >
> > -        if (nb_numa_nodes>  smp_cpus) {
> > -            nb_numa_nodes = smp_cpus;
> > +        if (nb_numa_nodes>  MAX_NODES) {
> > +            nb_numa_nodes = MAX_NODES;
> >           }
> >
> >           /* If no memory size if given for any node, assume the default
> > case
> >
> >
> 

-- 

Sasha.