From: "M. Mohan Kumar" <mohan@in.ibm.com>
To: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@gmail.com>
Subject: [Qemu-devel] [V10 PATCH 08/13] virtio-9p: Add support for removing file or directory
Date: Thu, 31 Mar 2011 13:51:35 +0530 [thread overview]
Message-ID: <1301559700-6742-9-git-send-email-mohan@in.ibm.com> (raw)
In-Reply-To: <1301559700-6742-1-git-send-email-mohan@in.ibm.com>
Support for removing file or directory in chroot environment. Add
interfaces to remove file/directory in chroot worker and qemu side.
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
---
hw/9pfs/virtio-9p-chroot-worker.c | 18 ++++++++++++++++++
hw/9pfs/virtio-9p-chroot.h | 1 +
hw/9pfs/virtio-9p-local.c | 3 +++
3 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/hw/9pfs/virtio-9p-chroot-worker.c b/hw/9pfs/virtio-9p-chroot-worker.c
index fc05fd0..40e572c 100644
--- a/hw/9pfs/virtio-9p-chroot-worker.c
+++ b/hw/9pfs/virtio-9p-chroot-worker.c
@@ -161,6 +161,21 @@ unset_uid:
return retval;
}
+/*
+ * Remove a file object
+ * Returns 0 on success and -errno on failure
+ */
+static int chroot_do_remove(V9fsFileObjectRequest *request)
+{
+ int retval;
+
+ retval = remove(request->path.path);
+ if (retval < 0) {
+ return -errno;
+ }
+ return 0;
+}
+
static void chroot_daemonize(int chroot_sock)
{
sigset_t sigset;
@@ -262,6 +277,9 @@ int v9fs_chroot(FsContext *fs_ctx)
case T_MKNOD:
retval = chroot_do_create_special(&request);
break;
+ case T_REMOVE:
+ retval = chroot_do_remove(&request);
+ break;
default:
retval = -1;
break;
diff --git a/hw/9pfs/virtio-9p-chroot.h b/hw/9pfs/virtio-9p-chroot.h
index 2192a05..856e9c4 100644
--- a/hw/9pfs/virtio-9p-chroot.h
+++ b/hw/9pfs/virtio-9p-chroot.h
@@ -9,6 +9,7 @@
#define T_MKNOD 4
#define T_SYMLINK 5
#define T_LINK 6
+#define T_REMOVE 7
union MsgControl {
struct cmsghdr cmsg;
diff --git a/hw/9pfs/virtio-9p-local.c b/hw/9pfs/virtio-9p-local.c
index 2ad2f00..7ae21ef 100644
--- a/hw/9pfs/virtio-9p-local.c
+++ b/hw/9pfs/virtio-9p-local.c
@@ -553,6 +553,9 @@ static int local_utimensat(FsContext *s, const char *path,
static int local_remove(FsContext *ctx, const char *path)
{
+ if (ctx->fs_sm == SM_PASSTHROUGH) {
+ return passthrough_request(ctx, NULL, path, 0, NULL, T_REMOVE);
+ }
return remove(rpath(ctx, path));
}
--
1.7.4
next prev parent reply other threads:[~2011-03-31 8:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 8:21 [Qemu-devel] [V10 PATCH 00/13] virtio-9p: Use chroot to safely access files in passthrough security model M. Mohan Kumar
2011-03-31 8:21 ` [Qemu-devel] [V10 PATCH 01/13] Implement qemu_read_full M. Mohan Kumar
2011-03-31 8:21 ` [Qemu-devel] [V10 PATCH 02/13] virtio-9p: Enable CONFIG_THREAD if CONFIG_VIRTFS is enabled M. Mohan Kumar
2011-03-31 8:21 ` [Qemu-devel] [V10 PATCH 03/13] virtio-9p: Provide chroot worker side interfaces M. Mohan Kumar
2011-03-31 8:21 ` [Qemu-devel] [V10 PATCH 04/13] virtio-9p: Add qemu side interfaces for chroot environment M. Mohan Kumar
2011-03-31 8:21 ` [Qemu-devel] [V10 PATCH 05/13] virtio-9p: Add support to open a file in " M. Mohan Kumar
2011-03-31 8:21 ` [Qemu-devel] [V10 PATCH 06/13] virtio-9p: Create support " M. Mohan Kumar
2011-03-31 8:21 ` [Qemu-devel] [V10 PATCH 07/13] virtio-9p: Support for creating special files M. Mohan Kumar
2011-03-31 8:21 ` M. Mohan Kumar [this message]
2011-03-31 8:21 ` [Qemu-devel] [V10 PATCH 09/13] virtio-9p: Add support to rename M. Mohan Kumar
2011-03-31 8:21 ` [Qemu-devel] [V10 PATCH 10/13] virtio-9p: Move file post creation changes to none security model M. Mohan Kumar
2011-03-31 8:21 ` [Qemu-devel] [V10 PATCH 11/13] virtio-9p: Add support for chmod M. Mohan Kumar
2011-03-31 8:21 ` [Qemu-devel] [V10 PATCH 12/13] virtio-9p: Add support for chown M. Mohan Kumar
2011-03-31 8:21 ` [Qemu-devel] [V10 PATCH 13/13] virtio-9p: Chroot environment for other functions M. Mohan Kumar
2011-04-08 8:44 ` [Qemu-devel] Re: [V10 PATCH 00/13] virtio-9p: Use chroot to safely access files in passthrough security model Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301559700-6742-9-git-send-email-mohan@in.ibm.com \
--to=mohan@in.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).