From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56683 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q5gAB-0007yA-7p
	for qemu-devel@nongnu.org; Fri, 01 Apr 2011 11:21:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1Q5gA9-0001sN-IW
	for qemu-devel@nongnu.org; Fri, 01 Apr 2011 11:21:26 -0400
Received: from e3.ny.us.ibm.com ([32.97.182.143]:49293)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1Q5gA9-0001qG-GH
	for qemu-devel@nongnu.org; Fri, 01 Apr 2011 11:21:25 -0400
Received: from d01dlp01.pok.ibm.com (d01dlp01.pok.ibm.com [9.56.224.56])
	by e3.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p31F0Me9015690
	for <qemu-devel@nongnu.org>; Fri, 1 Apr 2011 11:00:22 -0400
Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234])
	by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 57B4F38C803B
	for <qemu-devel@nongnu.org>; Fri,  1 Apr 2011 11:21:00 -0400 (EDT)
Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167])
	by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p31FL7HM416906
	for <qemu-devel@nongnu.org>; Fri, 1 Apr 2011 11:21:07 -0400
Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1])
	by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id p31FL6at022652
	for <qemu-devel@nongnu.org>; Fri, 1 Apr 2011 09:21:06 -0600
From: Michael Roth <mdroth@linux.vnet.ibm.com>
Date: Fri,  1 Apr 2011 10:20:53 -0500
Message-Id: <1301671255-27717-1-git-send-email-mdroth@linux.vnet.ibm.com>
Subject: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: mdroth@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com

Was playing around with Stefan's git hook for checkpatch.pl:

http://blog.vmsplice.net/2011/03/how-to-automatically-run-checkpatchpl.html

which seems really useful butter-finger coders such as myself. But some of warnings/errors that have carried over from the kernel have made this approach somewhat prohibitive for QEMU code.

These patches add a flag that let's checkpatch.pl exit successfully when we only have warnings, while still printing them and encouraging users to fix them.

We also make C99 //comments a warning instead of an error, since they don't actually violate QEMU's coding guidelines.