From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=43606 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q6Q4r-0003JK-Dy for qemu-devel@nongnu.org; Sun, 03 Apr 2011 12:23:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q6Q4h-0004af-0O for qemu-devel@nongnu.org; Sun, 03 Apr 2011 12:22:55 -0400 Received: from moutng.kundenserver.de ([212.227.126.171]:49403) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q6Q4g-0004aX-KP for qemu-devel@nongnu.org; Sun, 03 Apr 2011 12:22:50 -0400 From: Stefan Weil Date: Sun, 3 Apr 2011 18:22:45 +0200 Message-Id: <1301847765-8203-1-git-send-email-weil@mail.berlios.de> Subject: [Qemu-devel] [PATCH] darwin-user: Remove unneeded null pointer check List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: QEMU Developers cppcheck reports this error: commpage.c:223: error: Possible null pointer dereference: value - otherwise it is redundant to check if value is null at line 214 The null pointer check in line 214 is indeed not needed. If value were null, the code would crash in line 223. See do_compare_and_swap64 were for a reference. Signed-off-by: Stefan Weil --- darwin-user/commpage.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/darwin-user/commpage.c b/darwin-user/commpage.c index f6aa71e..cc29bdd 100644 --- a/darwin-user/commpage.c +++ b/darwin-user/commpage.c @@ -211,7 +211,7 @@ void do_compare_and_swap32(void *cpu_env, int num) uint32_t *value = (uint32_t*)((CPUX86State*)cpu_env)->regs[R_ECX]; DPRINTF("commpage: compare_and_swap32(%x,new,%p)\n", old, value); - if(value && old == tswap32(*value)) + if(old == tswap32(*value)) { uint32_t new = ((CPUX86State*)cpu_env)->regs[R_EDX]; *value = tswap32(new); -- 1.7.2.5