From: Jordan Justen <jordan.l.justen@intel.com>
To: qemu-devel@nongnu.org
Cc: Jordan Justen <jordan.l.justen@intel.com>
Subject: [Qemu-devel] [PATCH] hw/pflash_cfi02: Fix lazy reset of ROMD mode
Date: Sun, 3 Apr 2011 13:16:26 -0700 [thread overview]
Message-ID: <1301861786-6637-1-git-send-email-jordan.l.justen@intel.com> (raw)
When checking pfl->rom_mode for when to lazily reenter ROMD mode,
the value was check was the opposite of what it should have been.
This prevent the part from returning to ROMD mode after a write
was made to the CFI rom region.
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
---
hw/pflash_cfi02.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/pflash_cfi02.c b/hw/pflash_cfi02.c
index 30c8aa4..370c5ee 100644
--- a/hw/pflash_cfi02.c
+++ b/hw/pflash_cfi02.c
@@ -112,7 +112,7 @@ static uint32_t pflash_read (pflash_t *pfl, target_phys_addr_t offset,
DPRINTF("%s: offset " TARGET_FMT_plx "\n", __func__, offset);
ret = -1;
- if (pfl->rom_mode) {
+ if (!pfl->rom_mode) {
/* Lazy reset of to ROMD mode */
if (pfl->wcycle == 0)
pflash_register_memory(pfl, 1);
--
1.7.1
next reply other threads:[~2011-04-03 20:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-03 20:16 Jordan Justen [this message]
2011-04-09 16:35 ` [Qemu-devel] [PATCH] hw/pflash_cfi02: Fix lazy reset of ROMD mode Aurelien Jarno
2011-04-10 8:38 ` [Qemu-devel] " Jan Kiszka
2011-04-10 10:53 ` [Qemu-devel] [PATCH] pflash: Restore & fix lazy ROMD switching Jan Kiszka
2011-04-10 19:33 ` Jordan Justen
2011-04-11 5:27 ` Jan Kiszka
2011-04-26 7:42 ` Jan Kiszka
2011-04-27 14:31 ` Aurelien Jarno
2011-04-10 18:29 ` [Qemu-devel] Re: [PATCH] hw/pflash_cfi02: Fix lazy reset of ROMD mode Jordan Justen
-- strict thread matches above, loose matches on Subject: below --
2011-03-14 21:10 [Qemu-devel] " jordan.l.justen
2011-04-03 19:51 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301861786-6637-1-git-send-email-jordan.l.justen@intel.com \
--to=jordan.l.justen@intel.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).