From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59329 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q6hex-0002kP-8z for qemu-devel@nongnu.org; Mon, 04 Apr 2011 07:09:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q6heu-0006DU-Rr for qemu-devel@nongnu.org; Mon, 04 Apr 2011 07:09:26 -0400 Received: from mnementh.archaic.org.uk ([81.2.115.146]:33293) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q6heu-0006Cy-Kj for qemu-devel@nongnu.org; Mon, 04 Apr 2011 07:09:24 -0400 From: Peter Maydell Date: Mon, 4 Apr 2011 12:09:22 +0100 Message-Id: <1301915362-2626-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH] cpu-all.h: Remove unnecessary target-specific ifdef for CPU_QuadU List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Alexander Graf , Aurelien Jarno CPU_QuadU isn't used on all targets, but there's no harm in defining the typedef anyway. It only needs to be guarded by CONFIG_SOFTFLOAT, because softfloat-native doesn't have a float128 type. This avoids the need for every new target which uses CPU_QuadU to add itself to an #ifdef in what ought to be target-agnostic code. Signed-off-by: Peter Maydell --- Noticed this one as a result of the s390 support patches; seems like a minor but worthwhile cleanup to me... cpu-all.h | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/cpu-all.h b/cpu-all.h index 4cc445f..dc0f2f0 100644 --- a/cpu-all.h +++ b/cpu-all.h @@ -138,11 +138,10 @@ typedef union { uint64_t ll; } CPU_DoubleU; -#if defined(TARGET_SPARC) || defined(TARGET_S390X) +#if defined(CONFIG_SOFTFLOAT) typedef union { float128 q; -#if defined(HOST_WORDS_BIGENDIAN) \ - || (defined(__arm__) && !defined(__VFP_FP__) && !defined(CONFIG_SOFTFLOAT)) +#if defined(HOST_WORDS_BIGENDIAN) struct { uint32_t upmost; uint32_t upper; -- 1.7.1