From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Gibson <dwg@au1.ibm.com>
Cc: Alexander Graf <agraf@suse.de>, QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH] spapr_vscsi: Set uninitialized variable
Date: Tue, 05 Apr 2011 15:04:40 +1000 [thread overview]
Message-ID: <1301979880.2549.119.camel@pasglop> (raw)
In-Reply-To: <20110405041459.GC466@yookeroo>
On Tue, 2011-04-05 at 14:14 +1000, David Gibson wrote:
> > >@@ -255,7 +255,7 @@ static int vscsi_srp_direct_data(VSCSIState *s,
> vscsi_req *req,
> > > {
> > > struct srp_direct_buf *md = req->cur_desc;
> > > uint32_t llen;
> > >- int rc;
> > >+ int rc = 0;
> >
> > David, is this correct? Or would rc be -1 when !llen?
>
> I talked to Ben, who wrote this code - apparently his mail server blew
> up. This patch should be correct, AFAWCT. It's not totally clear
> what the right return value should be in thie case, or indeed that
> this case ever actually happens, but we think 0 is right.
Just double checked and we never call that function if len is 0
Cheers,
Ben.
next prev parent reply other threads:[~2011-04-05 5:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-03 16:21 [Qemu-devel] [PATCH] spapr_vscsi: Set uninitialized variable Stefan Weil
2011-04-04 15:03 ` [Qemu-devel] " Alexander Graf
2011-04-05 4:14 ` David Gibson
2011-04-05 5:04 ` Benjamin Herrenschmidt [this message]
2011-04-05 7:55 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301979880.2549.119.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=dwg@au1.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).