[Qemu-devel] [PATCH] scsi-generic: Remove bogus double complete

[David Gibson <david@gibson.dropbear.id.au>]

From: Ben Herrenschmidt <benh@kernel.crashing.org>

scsi-generic scsi_read_complete() should not -both- call the client
complete callback with SCSI_REASON_DATA -and- call
scsi_command_complete().  The former will cause the client to queue a
new read or write request, while the later will free the request data
structure, thus causing the new read or write request to use a
freed/stale structure when it completes.

This patch fixes the bug, fixing a crash with scsi-generic & RHEL5.5
installer.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 hw/scsi-generic.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c
index 9be1cca..c06f5df 100644
--- a/hw/scsi-generic.c
+++ b/hw/scsi-generic.c
@@ -173,8 +173,6 @@ static void scsi_read_complete(void * opaque, int ret)
 
     r->len = -1;
     r->req.bus->complete(r->req.bus, SCSI_REASON_DATA, r->req.tag, len);
-    if (len == 0)
-        scsi_command_complete(r, 0);
 }
 
 /* Read more data from scsi device into buffer.  */
-- 
1.7.1